Details
-
Type:
Improvement
-
Status:
Open
-
Priority:
Major
-
Resolution: Unresolved
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: core
-
Labels:None
-
Number of attachments :
Description
As discussed with Aslak and Paul (11/23/2004)...
We agreed there are cases where it is desirable for PicoContainer to self-register itself and become available for injection into child components. The guard code that used to prevent this operation from being done manually has been removed by Paul (see PICO-226).
Instead of introducing a ContainerExposingPicoContainer into Pico and having to specify it as the container-implementation, we will add an optional register-self attribute to the scripting system. This attribute will cause nano to register the container within itself.
Example:
<container register-self=true>
<component-implementation class='org.nanocontainer.testmodel.DefaultWebServerConfig'/> ...
Activity
Obie Fernandez
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Attachment | NANO-110.patch [ 13483 ] |
Please add to the testmodel java source tree.
Obie Fernandez
added a comment - Please add to the testmodel java source tree. Obie Fernandez
made changes -
| Attachment | TestDependsOnPicoContainer.java [ 13484 ] |
This feature was a wee bit more complicated to implement that I thought it would be. Without a guard clause in LifecycleVisitor you definitely get some nasty infinite loops.
Obie Fernandez
added a comment - This feature was a wee bit more complicated to implement that I thought it would be. Without a guard clause in LifecycleVisitor you definitely get some nasty infinite loops. Obie Fernandez
logged work - 04/Dec/04 3:01 PM -
- Time Spent:
- 8 hours
- Some of this time was spent pairing with Aslak on fixing the infinite loop in the container lifecycle that resulted from being able to self-register.
Obie Fernandez
made changes -
| Remaining Estimate | 2 days [ 172800 ] | 0 minutes [ 0 ] |
| Time Spent | 8 hours [ 28800 ] |
I'm not sure this feature should be implemented anymore.
Definately not as a 'container in list of components for self' as it will likely barf on start() because of the recursive nature of lifecycle management.
Its only really needed for resolution right ?
if we do it at all, it should perhaps be in AbstractNanoPicoContainer as ...
public final Object getComponentInstance(Object componentKey) throws PicoException {
//.....
if (selfRegistered && componentKey instanceof Class) {
Class classKey = (Class) componentKey;
if (classKey.isAssignableFrom(this.getClass())
}
//.....
}
Paul Hammant
added a comment - I'm not sure this feature should be implemented anymore.
Definately not as a 'container in list of components for self' as it will likely barf on start() because of the recursive nature of lifecycle management.
Its only really needed for resolution right ?
if we do it at all, it should perhaps be in AbstractNanoPicoContainer as ...
public final Object getComponentInstance(Object componentKey) throws PicoException {
//.....
if (selfRegistered && componentKey instanceof Class) {
Class classKey = (Class) componentKey;
if (classKey.isAssignableFrom(this.getClass())
{
return this;
}
}
//.....
} peter royal
made changes -
The patch to allow self-registration. There is one new class in testmodel, which I will attach next.