NanoContainer
  1. NanoContainer
  2. NANO-130

hibernate3 module updated to hibernate3-rc1 (api changed)

          Details

          • Type: Improvement Improvement
          • Status: Closed Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: None
          • Fix Version/s: None
          • Component/s: hibernate
          • Labels:
            None
          • Number of attachments :
            2

            Issue Links

            is related to

            Improvement - An improvement or enhancement to an existing feature or task. NANO-132 hibernate3 module upgrade for hb3-FINAL VERSION! THERE IS API CHANGE!

            • Major - Major loss of function.
            • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

              Activity

              Jose Peleteiro made changes -
              Field Original Value New Value
              Attachment hibernate3.zip [ 14151 ]
              Jose Peleteiro made changes -
              Attachment hibernate3.patch [ 14152 ]
              Hide
              Permalink
              Aslak Hellesøy added a comment -

              This patch moves old classes to a new package, and it's impossible to see what changed. Wouldn't it make more sense to keep the original package name rather than having 2 sets of semi-identical nano-hibernate classes?

              Show
              Aslak Hellesøy added a comment - This patch moves old classes to a new package, and it's impossible to see what changed. Wouldn't it make more sense to keep the original package name rather than having 2 sets of semi-identical nano-hibernate classes?
              Aslak Hellesøy made changes -
              Link This issue is related to NANO-132 [ NANO-132 ]
              Hide
              Permalink
              Aslak Hellesøy added a comment -

              Jose, as described in NANO-132, your patch should be in a patch format:

              I'm not keen on adding all of these classes that seem to be minor modification of the original org.nanocontainer.hibernate package, except that your classes are in a different package - the maintenance burden of 2 quasi-similar packages seems too high.

              Could you refactor your classes to be in the same package and submit a patch? Aslo see: http://picocontainer.org/How+To+Contribute

              Show
              Aslak Hellesøy added a comment - Jose, as described in NANO-132 , your patch should be in a patch format: I'm not keen on adding all of these classes that seem to be minor modification of the original org.nanocontainer.hibernate package, except that your classes are in a different package - the maintenance burden of 2 quasi-similar packages seems too high. Could you refactor your classes to be in the same package and submit a patch? Aslo see: http://picocontainer.org/How+To+Contribute
              Hide
              Permalink
              Konstantin Pribluda added a comment -

              Aslak, since hibernate-3 has changed API it gonna be in own subroject...

              Show
              Konstantin Pribluda added a comment - Aslak, since hibernate-3 has changed API it gonna be in own subroject...
              Jörg Schaible made changes -
              Component/s hibernate [ 10688 ]
              Hide
              Permalink
              Mauro Talevi added a comment -

              Obsoleted by NANO-132

              Show
              Mauro Talevi added a comment - Obsoleted by NANO-132
              Mauro Talevi made changes -
              Resolution Fixed [ 1 ]
              Status Open [ 1 ] Closed [ 6 ]

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Jose Peleteiro
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: