NanoContainer
  1. NanoContainer
  2. NANO-146

Make NanoContainerDeployer.getDeploymentScript() a protected method

    Details

    • Type: Wish Wish
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0-RC2
    • Component/s: deployer
    • Labels:
      None
    • Number of attachments :
      0

      Description

      I've got a system where I could use everything about NanoContainer Deployer EXCEPT that I have my composition script in a different location inside the virtual file object. If we considered NanoContainer.getDeploymentScript() more of a template method and made it protected, it would save me a lot of time in the long run and I'd still get to test out/improve the main Deployer code.

      If there was an objection to just making it protected, I wouldn't mind creating an abstract base class for NanoContainerDeployer that took care of the common tasks and made getDeploymentScript() a "pure virtual" function that way.

      ie:

      abstract public class AbstractNanoContainerDeployer() {
      .....
      abstract protected FileObject getDeploymentScript(FileObject applicationFolder);
      }

        Activity

        Mauro Talevi made changes -
        Field Original Value New Value
        Project NanoContainer Sandbox [ 11010 ] NanoContainer [ 10121 ]
        Key NANOSANDBOX-9 NANO-146
        Component/s deployer [ 11788 ]
        Component/s deployer [ 11641 ]
        Hide
        Michael Rimov added a comment -

        Completed.

        Show
        Michael Rimov added a comment - Completed.
        Michael Rimov made changes -
        Resolution Fixed [ 1 ]
        Fix Version/s 1.0-RC2 [ 11851 ]
        Status Open [ 1 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Michael Rimov
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: