Details
-
Type: Bug
-
Status: Closed
-
Priority: Minor
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: deployer
-
Labels:None
-
Environment:Windows JDK 1.5. Using Latest SVN code.
-
Testcase included:yes
-
Number of attachments :
Description
A couple of issues with deployer:
It would:
1 - Search indefinitely deep and only return the first in the array. So something in the lines of:
META-INF
-nanocontainer.groovy |
-.svn |
--nanocontainer.svn.props-base |
Would return nanocontainer.svn.props-base instead of the correct file. Fix only searches one layer deep. (Tested against VFS's SVN source base)
2 - Null Pointer Exception if the wrong type of file extension is found. (Given the above case, I bet you can't figure out why I found this bug ) Fixed.
3 - Added test cases for badly formed jar files and badly named scripts. (malformed-deployment.jar and badbuildscriptdeploy.jar respectively)
4 - Added a constructor to NanoContainerDeployer to not have to hard code the configuration script name. (before hardcoded to 'nanocontainer') the old default is provided.
The entire zip file should be able to drop into nanocontainer-sandbox\trunk\deployer\src and test case jars and patch files should match up. I'll be happy to modify the exceptio handling as per my post to the list and/or modify anything else in the design mods.
Activity
Field | Original Value | New Value |
---|---|---|
Key |
|
|
Component/s | deployer [ 10686 ] | |
Component/s | deployer [ 11623 ] | |
Project | NanoContainer [ 10121 ] | NanoTools [ 11002 ] |
Component/s | deployer [ 11623 ] | |
Project | NanoContainer Tools [ 11002 ] | NanoContainer Sandbox [ 11010 ] |
Key |
|
|
Component/s | deployer [ 11641 ] | |
Description |
A couple of issues with deployer: It would: 1 - Search indefinitely deep and only return the first in the array. So something in the lines of: META-INF |-nanocontainer.groovy |-.svn |--nanocontainer.svn.props-base Would return nanocontainer.svn.props-base instead of the correct file. Fix only searches one layer deep. (Tested against VFS's SVN source base) 2 - Null Pointer Exception if the wrong type of file extension is found. (Given the above case, I bet you can't figure out why I found this bug ;) ) Fixed. 3 - Added test cases for badly formed jar files and badly named scripts. (malformed-deployment.jar and badbuildscriptdeploy.jar respectively) 4 - Added a constructor to NanoContainerDeployer to not have to hard code the configuration script name. (before hardcoded to 'nanocontainer') -- the old default is provided. The entire zip file should be able to drop into nanocontainer-sandbox\trunk\deployer\src and test case jars and patch files should match up. I'll be happy to modify the exceptio handling as per my post to the list and/or modify anything else in the design mods. |
A couple of issues with deployer: It would: 1 - Search indefinitely deep and only return the first in the array. So something in the lines of: META-INF |-nanocontainer.groovy |-.svn |--nanocontainer.svn.props-base Would return nanocontainer.svn.props-base instead of the correct file. Fix only searches one layer deep. (Tested against VFS's SVN source base) 2 - Null Pointer Exception if the wrong type of file extension is found. (Given the above case, I bet you can't figure out why I found this bug ;) ) Fixed. 3 - Added test cases for badly formed jar files and badly named scripts. (malformed-deployment.jar and badbuildscriptdeploy.jar respectively) 4 - Added a constructor to NanoContainerDeployer to not have to hard code the configuration script name. (before hardcoded to 'nanocontainer') -- the old default is provided. The entire zip file should be able to drop into nanocontainer-sandbox\trunk\deployer\src and test case jars and patch files should match up. I'll be happy to modify the exceptio handling as per my post to the list and/or modify anything else in the design mods. |
Attachment | deployer-patch.zip [ 16177 ] |
Assignee | Joerg Schaible [ joehni ] |
Status | Open [ 1 ] | Closed [ 6 ] |
Resolution | Fixed [ 1 ] |
Key |
|
|
Component/s | deployer [ 11788 ] | |
Project | NanoContainer Sandbox [ 11010 ] | NanoContainer [ 10121 ] |
Component/s | deployer [ 11641 ] |
P.S. Multiproject works now with deployer included:
Index: project.properties
{maven.multiproject.basedir}===================================================================
project.properties (revision 2060)
+++ project.properties (working copy)
@@ -32,7 +32,7 @@
maven.multiproject.aggregateDir=components/
maven.multiproject.includes=*/project.xml
#the following fail and therefore are excluded
-maven.multiproject.excludes=idea/project.xml,deployer/project.xml
+maven.multiproject.excludes=idea/project.xml
maven.simian.linecount = 4
maven.license.licenseFile=$
/LICENSE.txt