Modifiable/Overridable ScriptedContainerBuilderFactory

New CustomGroovyNodeBuilder is now the default node builder.

Whoops – wrong issue I commented on last time. Patch is applied and committed.

I am refactoring my patch as I realized it was MUCH too 'static'y.

Hi All,

I've got a problem. I seem to be stuck between two issues to get what I want. The solution I checked into SVN to resolve what I need has zero behavior differences. But it uses statics, and of course, the whole point is to try to avoid that.

But that means (to me) changing the constructor so I can delay instantiation of the ScriptedBuilderFactory. But that changes the behavior of the class like so:

try

catch (ClassNotFoundException ex)

//Old Behavior – No Chance of error occuring on function call.
//New Behavior – BuilderClassNotFoundException could be thrown here.
ScriptedContainerBuilder builder = factory.getContainerBuilder();

So somebody that wrote code like that above could have their code fail on them suddenly when they thought they had it all taken care of. (Its a rare case, mind you!)

So I've included a patch with the new code so you can examine it. Is this change in behavior ok for Pico standards? (All current test cases pass fine)

Thanks for taking a look!

Can't see much wrong in moving away from static.
New staticless doesn't seem to me a source of problems either.
I would +1 unless someone can state a reason for keeping static.

With lazy initialization we have more code, that might fail at runtime (e.g. the pool is exhausted, the connection to the EJB failed). Therefore I'm fine with less statics.

Well, after begging and pleading with Mauro and Paul to let me take another crack at this, I undid my previous commit and took another shot at it. This time, I moved the code that Deployer relied on as a static factory into a new class called ScriptBuilderResolver. Using this you can now replace builder implementations for existing types or create new file types through code similar to this:

ScriptBuilderResolver resolver = new ScriptBuilderResolver();
resolver.registerBuilder(".groovy", "org.example.MySpecialGroovyBuilder");

ScriptedContainerBuilderFactory factory = new ScriptedContainerBuilderFactory(new File("MyCustomFile.groovy"), Thread.currentThread().getCustomClassLoader(), resolver);

ScriptedContainerBuilder builder = factory.getBuilder();
assert "org.example.MySpecialGroovyBuilder".equals(builder.getClass().getName());

Example Use Case For This Code:

I have a custom ComponentAdapter that relies on some other initialization code to occur after composition before becoming fully functional. Unfortunately, the default Groovy builder automatically called PicoContainer.start() on the container thus throwing all sorts of awful exceptions. By creating my own groovy builder that simply didn't call PicoContainer.start() until I was ready for it, problem was solved.

Final Note:

This version MUCH more closely matches the behavior in the RC-1 implementation because exceptions are thrown in the constructor like they were before.

HTH!

-Mike (R)