Details
-
Type:
Improvement
-
Status:
Open
-
Priority:
Major
-
Resolution: Unresolved
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
-
Testcase included:yes
-
Number of attachments :
Description
While there are five constructors for the ComponentParameter from Pico:
ComponentParameter()
Expect any scalar paramter of the appropriate type or an Array.
ComponentParameter(boolean emptyCollection)
Expect any scalar paramter of the appropriate type or an Array.
ComponentParameter(Class componentValueType, boolean emptyCollection)
Expect any scalar paramter of the appropriate type or the collecting type Array,Collectionor Map.
ComponentParameter(Class componentKeyType, Class componentValueType, boolean emptyCollection)
Expect any scalar paramter of the appropriate type or the collecting type Array,Collectionor Map.
ComponentParameter(Object componentKey)
Expect a parameter matching a component of a specific key.
Only two of these are supported within the XMLContainerBuilder. This precludes important use cases such as empty List and Map support. See here:
http://www.picocontainer.org/Arrays,+Collections+and+Maps
I have modified the XMLContainerBuilder and the DTD to support three additional attributes: emptyCollection, componentValueType, and componentKeyType. I added copious documentation and error checking on these cases as well, as well as test cases.
Perhaps analogous support should be added for the other builders?
Activity
Jeff Steward
logged work - 21/May/07 12:55 AM -
- Time Spent:
- 3 hours
- Finished the case for the XMLContainerBuilder. I think similar work needs to be done for the other builders.
Jeff Steward
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Remaining Estimate | 3 hours [ 10800 ] | 6 hours [ 21600 ] |
| Time Spent | 3 hours [ 10800 ] |
Applied. Can you take a look at http://svn.codehaus.org/picocontainer/java/sandbox/baby-steps/nano2/container/ and see it its right for Pico & Nano 2.0 please ?
Paul Hammant
added a comment - Applied. Can you take a look at http://svn.codehaus.org/picocontainer/java/sandbox/baby-steps/nano2/container/ and see it its right for Pico & Nano 2.0 please ? Looks good for nano2 as well. Attached is the patch with test cases.
Jeff Steward
added a comment - Looks good for nano2 as well. Attached is the patch with test cases. Jeff Steward
made changes -
| Attachment | Nano2-XMLContainerBuilder.patch [ 27493 ] |
In addition, a MapSupport test was left out of the original patch. Here is a patch for the XMLContainerBuilderTestCase for trunk.
Jeff Steward
added a comment - In addition, a MapSupport test was left out of the original patch. Here is a patch for the XMLContainerBuilderTestCase for trunk. Jeff Steward
made changes -
| Attachment | XMLContainerBuilder-MapSupport-test.patch [ 27494 ] |
Jeff can you attach the whole of the dtd for Nano2, the diff is huge, and unapplicable on my Mac. Cheers.
Paul Hammant
added a comment - Jeff can you attach the whole of the dtd for Nano2, the diff is huge, and unapplicable on my Mac. Cheers. Sure. I wonder why the diff ended up being so large. There are three files I changed - the dtd, the XMLContainerBuilder, and the XMLContainerBuilderTestCase. Did the others come across okay?
Jeff Steward
added a comment - Sure. I wonder why the diff ended up being so large. There are three files I changed - the dtd, the XMLContainerBuilder, and the XMLContainerBuilderTestCase. Did the others come across okay?
Jeff Steward
made changes -
| Attachment | nanocontainer-xml-1_0.dtd [ 27502 ] |
we should probably bump the dtd versions for both 1.x and 2.x before release
Paul Hammant
added a comment - we should probably bump the dtd versions for both 1.x and 2.x before release 
This also required changing the TestModel to add two classes to show support for Lists and Maps.