Details
-
Type:
Improvement
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 1.0-beta-1
-
Component/s: None
-
Labels:None
-
Number of attachments :
Description
it's no longer possible (since extensionsToComposers became private, which actually happens to be good design) to use a custom ContainerBuilder with NanoContainer.
I think that it would be better if only the constructos that take File arguments used the filename extensions to resolve ScriptedContainerBuilder class. All constructors that currently take an extension argument, should take the builder's class name.
Activity
Rafal Krzewski
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Attachment | nanoContainerBuilder.diff [ 11480 ] |
Fixed . thankyouu.
Show
Aslak Hellesøy
added a comment - Fixed . thankyouu.
Aslak Hellesøy
added a comment - Fixed . thankyouu. Aslak Hellesøy
made changes -
| Resolution | Fixed [ 1 ] | |
| Fix Version/s | 1.0-alpha-1 [ 10146 ] | |
| Assignee | Aslak Hellesoy [ rinkrank ] | |
| Status | Open [ 1 ] | Closed [ 6 ] |
a patch that introduces the described change (i.e. extension -> builderClass in constructor parameters)