NanoContainer
  1. NanoContainer
  2. NANO-46

PicoActionDispatcher shall not work with servlet request

          Details

          • Type: Bug Bug
          • Status: Closed Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.0-beta-1
          • Fix Version/s: 1.0-beta-1
          • Component/s: nanowar
          • Labels:
            None
          • Number of attachments :
            2

            Description

            Storing reference to request level container in HttpServletRequest
            obtained from ServletActionContext is really uncool, because it's not guaranted that servlet request is there.

            Webwork actions can be invoked in tests, and fail with NPE
            ( well, there is not HTTPRequest around... )

            I think request level container shall be stored on ActionContext...

            1. Java Source File
              ActionContextScopeObjectReference.java
              0.6 kB
              Konstantin Pribluda
            2. File
              afactory.diff
              0.7 kB
              Konstantin Pribluda

              Issue Links

              is duplicated by

              Improvement - An improvement or enhancement to an existing feature or task. NANOWAR-1 XWork integration that WebWork integrations builds on.

              • Major - Major loss of function.
              • Open - The issue is open and ready for the assignee to start work on it.

                Activity

                Hide
                Permalink
                Konstantin Pribluda added a comment -

                I propose doing like webwork does - fallback to ActionContext if there is no request.

                Attachments follow

                Show
                Konstantin Pribluda added a comment - I propose doing like webwork does - fallback to ActionContext if there is no request. Attachments follow
                Hide
                Permalink
                Konstantin Pribluda added a comment -

                object reference looking in action context

                Show
                Konstantin Pribluda added a comment - object reference looking in action context
                Konstantin Pribluda made changes -
                Field Original Value New Value
                Attachment ActionContextScopeObjectReference.java [ 11485 ]
                Hide
                Permalink
                Konstantin Pribluda added a comment -

                difff for pico action factory

                Show
                Konstantin Pribluda added a comment - difff for pico action factory
                Konstantin Pribluda made changes -
                Attachment afactory.diff [ 11486 ]
                Hide
                Permalink
                Philipp Meier added a comment -

                I think Pico-139 shows the whole picture of this issue.

                Show
                Philipp Meier added a comment - I think Pico-139 shows the whole picture of this issue.
                Philipp Meier made changes -
                Link This issue is duplicated by PICO-139 [ PICO-139 ]
                Aslak Hellesøy made changes -
                Component/s servlet [ 10682 ]
                Project PicoContainer [ 10120 ] NanoContainer [ 10121 ]
                Key PICO-141 NANO-46
                Affects Version/s 1.0-beta-1 [ 10147 ]
                Component/s picoextras-webwork [ 10563 ]
                Hide
                Permalink
                Konstantin Pribluda added a comment -

                this issue does not exist.... ( pico-139 )

                Which one did you meant?

                Show
                Konstantin Pribluda added a comment - this issue does not exist.... ( pico-139 ) Which one did you meant?
                Konstantin Pribluda made changes -
                Assignee Konstantin Pribluda [ ko5tik ]
                Konstantin Pribluda made changes -
                Component/s webwork [ 10641 ]
                Fix Version/s 1.0-beta-1 [ 10147 ]
                Component/s servlet [ 10682 ]
                Konstantin Pribluda made changes -
                Resolution Fixed [ 1 ]
                Status Open [ 1 ] Closed [ 6 ]

                  People

                  • Assignee:
                    Konstantin Pribluda
                    Reporter:
                    Konstantin Pribluda
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: