NanoContainer
  1. NanoContainer
  2. NANO-60

CachingScriptClassLoader does not reload modified scripts

          Details

          • Type: Bug Bug
          • Status: Closed Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: None
          • Fix Version/s: 1.0-beta-1
          • Component/s: nanowar
          • Labels:
            None
          • Environment:
            Groovy 1.0 beta4, Jetty 4.2.19
          • Number of attachments :
            1

            Description

            URLConnection#getDate() is not appropriate to detect scripts modification. (because, always return 0 for file protocol)
            URLConnection#getLastModified() seems to work well.

            And I suppose, HashMap (groovyActionLoadTimestamps and scriptClasses) should be synchronized.

              Activity

              Kouhei Mori made changes -
              Field Original Value New Value
              Attachment CachingScriptClassLoader.diff [ 11729 ]
              Hide
              Permalink
              Aslak Hellesøy added a comment -

              Nice patch!

              Show
              Aslak Hellesøy added a comment - Nice patch!
              Aslak Hellesøy made changes -
              Resolution Fixed [ 1 ]
              Fix Version/s 1.0-beta-1 [ 10147 ]
              Assignee Aslak Hellesoy [ rinkrank ]
              Status Open [ 1 ] Closed [ 6 ]

                People

                • Assignee:
                  Aslak Hellesøy
                  Reporter:
                  Kouhei Mori
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: