NanoContainer
  1. NanoContainer
  2. NANO-67

Specifying TestComp.jar location in tests

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Incomplete
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: core
    • Labels:
      None
    • Number of attachments :
      0

      Description

      In DefaultReflectionFrontEndTestCase and JavascriptContainerBuilderTestCase, there is code like:

      // Paul's path to TestComp. PLEASE do not take out.
      //testcompJarFileName = "D:/DEV/nano/reflection/src/test-comp/TestComp.jar";

      assertNotNull("The testcomp.jar system property should point to nano/reflection/src/test-comp/TestComp.jar", testcompJarFileName);
      File testCompJar = new File(testcompJarFileName);
      File testCompJar2 = new File(testCompJar.getParentFile(), "TestComp2.jar");
      assertTrue(testCompJar.isFile());
      assertTrue(testCompJar2.isFile());

      Can we make the filename configurable, like through a system property? Or we could pick it up from the classpath.

        Activity

        Hide
        Jörg Schaible added a comment -

        Well, what's the problem with it? As you can reed in the assertion, the TestComp.jar is already configured by a system property. I can run all of these tests flawlessly in Eclipse under Linux ...

        Show
        Jörg Schaible added a comment - Well, what's the problem with it? As you can reed in the assertion, the TestComp.jar is already configured by a system property. I can run all of these tests flawlessly in Eclipse under Linux ...
        Hide
        Aslak Hellesøy added a comment -

        The system property has been there all the time....

        Show
        Aslak Hellesøy added a comment - The system property has been there all the time....
        Aslak Hellesøy made changes -
        Field Original Value New Value
        Resolution Incomplete [ 4 ]
        Status Open [ 1 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Miguel Paraz
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: