Details
Task
Closed
Major
Description
James wrote the PicoBuilder class in groovy subproject. It was not well understood by those of us new to Groovy and its builder concept.
Now that I understand it, it's critical that this functionality gets consumed into the main NanoContainer project. Specifically org.nanocontainer.script.groovy
It needs a rename. Given the rename will have the word 'Groovy' and 'Builder' in it, it won't exaclty stick out as different to the current GroovyContainerBuilder.
Perhaps it should be TrueGroovyContainerBuilder (never let me name anything).
Anyway, the BuilderSupport aspect of this is the bit that is magic. Theat must be upgraded to
- support different implementations of MutablePicoContainer
- leverage DefaultReflectionComponentAdapter
- thus take string representations of key/impl that
are loadable classes to the groovy script env
executing the script.
When consumed, kill James' groovy sub-project please.
Activity
Tis now called NanoContainerBuilder. Aslak fixed the failing testcase months ago.
Paul Hammant
added a comment - Tis now called NanoContainerBuilder. Aslak fixed the failing testcase months ago. Paul Hammant
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Resolution | Fixed [ 1 ] | |
| Status | Open [ 1 ] | Closed [ 6 ] |
Classes moved. I can;t get the GroovyTestCase to be run though. Will seek James's opinion on how to do it.
The builder still needs to be renamed (PicoBuilder is poor name).
Also, as with other NanoContainer script impls, it needs to cater with string class names, both for key and impl.
We need to do this so that ..
http://cvs.picocontainer.codehaus.org/java/megacontainer/src/testcomp/composition.groovy
.. is more elegant when implemented in real GroovyBuilder