PicoContainer
  1. PicoContainer
  2. PICO-1

DependencyStrategy and DependencyIntrospector

          Details

          • Type: Improvement Improvement
          • Status: Closed Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: None
          • Fix Version/s: 1.0-alpha-2
          • Component/s: None
          • Labels:
            None
          • Number of attachments :
            2

            Description

            This is from Mike Hogan:

            Fellas,

            I've attached a jar that contains a very "impressionistic sketch" of what
            this dependency stragety thing might look like. It should solidify the
            discussions we've been having. I've implemented a constructor strategy and
            a method name strategy. Check out
            MethodNameDependencyStrategyJUnitTest.java and
            ConstructorDependencyStrategyJUnitTest.java.

            I think this could be a good addition to Pico and would offer tremendous
            flexibility. What ya reckon?

            Cheers,
            Mike.

              Activity

              Hide
              Permalink
              Aslak Hellesøy added a comment -

              It looks very good, but it's kinda hard to apply in its current form since you haven't patched HierarchicalPicoContainer/ComponentFactory files, but forked them. This applies to Wilma and Fred too.

              Could you upload a new patch by following the patching instructions on XDoclet's JIRA? (In red).

              (One of these days I'll write a patch plugin for Maven, with goals for create and apply).

              http://opensource.atlassian.com/projects/xdoclet/

              Show
              Aslak Hellesøy added a comment - It looks very good, but it's kinda hard to apply in its current form since you haven't patched HierarchicalPicoContainer/ComponentFactory files, but forked them. This applies to Wilma and Fred too. Could you upload a new patch by following the patching instructions on XDoclet's JIRA? (In red). (One of these days I'll write a patch plugin for Maven, with goals for create and apply). http://opensource.atlassian.com/projects/xdoclet/
              Hide
              Permalink
              Mike Hogan added a comment -

              Guys,

              Here is the patch for the dependency strategy. There are quite a few files touched. A few comments:

              • DefaultComponentFactory and WrongNumberOfConstructorsRegistrationException are no longer needed.
              • I dropped the constructor check test from HierarchicalPicoContainerTestCase

              Any problems, gimme a shout.

              Thanks,
              Mike.

              Show
              Mike Hogan added a comment - Guys, Here is the patch for the dependency strategy. There are quite a few files touched. A few comments: DefaultComponentFactory and WrongNumberOfConstructorsRegistrationException are no longer needed. I dropped the constructor check test from HierarchicalPicoContainerTestCase Any problems, gimme a shout. Thanks, Mike.
              Hide
              Permalink
              Aslak Hellesøy added a comment -

              Jon, since Mike's patch is similar to yours, I hope you can handle this issue.

              Show
              Aslak Hellesøy added a comment - Jon, since Mike's patch is similar to yours, I hope you can handle this issue.
              Hide
              Permalink
              Aslak Hellesøy added a comment -

              Temporarily reassigning to myself to check that email notification works in JIRA. Will set it back to Jon later.

              Show
              Aslak Hellesøy added a comment - Temporarily reassigning to myself to check that email notification works in JIRA. Will set it back to Jon later.
              Hide
              Permalink
              Aslak Hellesøy added a comment -

              Back to you Jon

              Show
              Aslak Hellesøy added a comment - Back to you Jon
              Hide
              Permalink
              Aslak Hellesøy added a comment -

              Applied with modifications. In fact, Mike Jon and Aslak wrote the same code thrice! CVS has a mix of all of these.

              Show
              Aslak Hellesøy added a comment - Applied with modifications. In fact, Mike Jon and Aslak wrote the same code thrice! CVS has a mix of all of these.
              Hide
              Permalink
              Aslak Hellesøy added a comment -

              test fish

              Show
              Aslak Hellesøy added a comment - test fish

                People

                • Assignee:
                  Jon Tirsen
                  Reporter:
                  Aslak Hellesøy
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: