Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Critical
-
Resolution: Fixed
-
Affects Version/s: 1.0-beta-5
-
Fix Version/s: 1.0-beta-5
-
Component/s: PicoContainer (Java)
-
Labels:None
-
Number of attachments :
Description
A ConstantParameter instanciates a InstanceComponentAdapter with
the value itself as key and registers it in the pico. This is
critical if the value of the parameter equals a key of a component.
Verifying the container throws then a TooManySatisfiableConstructorsException.
In worst case scenario, the value could have been configured by an
admin breaking the application by chance.
To solve the problem create unique keys for adapters holding
constant parameters, allow a null value as key or remove the key at
all as proposed in PICO-105, since it is not used anyway in this
context.
Activity
Jörg Schaible
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Attachment | ParameterTestCase.java.diff [ 11330 ] |
Closing this since the attached test does no longer throw any exceptions.
Aslak Hellesøy
added a comment - Closing this since the attached test does no longer throw any exceptions. Aslak Hellesøy
made changes -
| Fix Version/s | 1.0-beta-5 [ 10145 ] | |
| Status | Open [ 1 ] | Closed [ 6 ] |
| Resolution | Fixed [ 1 ] | |
| Assignee | Aslak Hellesoy [ rinkrank ] |
Reopened upon Jorg's request. If you create new attachments, please mention which ones (1, 2, etc) are obsolete.
Aslak Hellesøy
added a comment - Reopened upon Jorg's request. If you create new attachments, please mention which ones (1, 2, etc) are obsolete. Aslak Hellesøy
made changes -
| Status | Closed [ 6 ] | Reopened [ 4 ] |
| Resolution | Fixed [ 1 ] |
ParameterTestCase.java.diff: Modified test case.
Well, it is difficult to knew the number of the attachment before submitting them (I've seen JIRA renumber them anyway). Safest procedure is to open the link to the "attachment management" and use the newer one.
Jörg Schaible
added a comment - ParameterTestCase.java.diff: Modified test case.
Well, it is difficult to knew the number of the attachment before submitting them (I've seen JIRA renumber them anyway). Safest procedure is to open the link to the "attachment management" and use the newer one. Jörg Schaible
made changes -
| Attachment | ParameterTestCase.java.diff [ 11454 ] |
PicoContainer\java\picocontainer\ConstantParameter.java.diff: Patch to solve the problem by creating "unique" names.
But the original question still applies: Why have the ConstantParameters to be registered, since their key is never requested ...
Jörg Schaible
added a comment - PicoContainer\java\picocontainer\ConstantParameter.java.diff: Patch to solve the problem by creating "unique" names.
But the original question still applies: Why have the ConstantParameters to be registered, since their key is never requested ... Jörg Schaible
made changes -
| Attachment | ConstantParameter.java.diff [ 11455 ] |
Applied, with minor modification. (Using the hash code as key.)
Aslak Hellesøy
added a comment - Applied, with minor modification. (Using the hash code as key.) Aslak Hellesøy
made changes -
| Status | Reopened [ 4 ] | Closed [ 6 ] |
| Resolution | Fixed [ 1 ] |
src\test\org\picocontainer\defaults\ParameterTestCase.java.diff
Patch to add a fixture for paarmeter test case, that demonstrates the bug.