Details
-
Type:
Improvement
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 1.0-beta-5
-
Component/s: PicoContainer (Java)
-
Labels:None
-
Number of attachments :
Description
In ConstructorComponentAdapter.getAllSatisfiableConstructors(List constructors, PicoContainer picoContainer), the index i is on currentParameters.
If parameterTypes[] (derived from the list of current contructor parameters) has less elements than currentParameters, access to parameterTypes[i] will be out of bounds and throw ArrayIndexOutOfBoundsException.
I think the lengths should be verified and an appropriate Exception be thrown before entering the 'for' loop.
Issue Links
- is duplicated by
-
PICO-131
Honor given parameter types instantiating components
-
Activity
Aslak Hellesøy
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Assignee | Aslak Hellesoy [ rinkrank ] | |
| Resolution | Fixed [ 1 ] | |
| Status | Open [ 1 ] | Closed [ 6 ] |
| Fix Version/s | 1.0-beta-5 [ 10145 ] |
Well, sorry, no. The Exception is raised on the parameters field, not on the ctor list/array. Fix provided with PICO-131.
Show
Jörg Schaible
added a comment - Well, sorry, no. The Exception is raised on the parameters field, not on the ctor list/array. Fix provided with PICO-131 .
Jörg Schaible
added a comment - Well, sorry, no. The Exception is raised on the parameters field, not on the ctor list/array. Fix provided with PICO-131 . Aslak Hellesøy
made changes -
I believe this is fixed. If not, please provide a failing test case to illustrate the bug.