PicoContainer
  1. PicoContainer
  2. PICO-133

update Picocontainer tests to work with latest JMock CVS

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0-beta-5
    • Fix Version/s: 1.0-beta-5
    • Component/s: None
    • Labels:
      None
    • Environment:
      running unit tests with latest JMock CVS
    • Number of attachments :
      2

      Description

      I was having a look at how Picocontainer used JMock because I was interested in using it in my own project, but then found that the tests using JMock in Picocontainer to be running against an old snapshot of JMock. I grabbed the latest JMock CVS, built it, updated Picocontainer testcases to use the latest JMock to learn how to use it and figured I'd contribute my changes back to the project.

      BTW, I did have to modify org.jmock.dynamic.DynamicUtil to fix a null pointer exception, but I've provided that patch here:
      http://jira.codehaus.org/secure/ViewIssue.jspa?key=JMOCK-3

      Patch coming up.

      Jake

      1. picotest_jmock_new.patch.diff
        8 kB
        Jacob Kjome
      2. picotest_jmock.patch.diff
        8 kB
        Jacob Kjome

        Activity

        Hide
        Jacob Kjome added a comment -

        patch updating all tests in Picocontainer CVS which use JMock to work against the latest JMock CVS.

        Jake

        Show
        Jacob Kjome added a comment - patch updating all tests in Picocontainer CVS which use JMock to work against the latest JMock CVS. Jake
        Jacob Kjome made changes -
        Field Original Value New Value
        Attachment picotest_jmock.patch.diff [ 11395 ]
        Hide
        Jacob Kjome added a comment -

        Updated patch to fix conflicting changes in latest CVS.

        Jake

        Show
        Jacob Kjome added a comment - Updated patch to fix conflicting changes in latest CVS. Jake
        Jacob Kjome made changes -
        Attachment picotest_jmock_new.patch.diff [ 11412 ]
        Aslak Hellesøy made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Closed [ 6 ]
        Assignee Aslak Hellesoy [ rinkrank ]
        Fix Version/s 1.0-beta-5 [ 10145 ]
        Hide
        Jacob Kjome added a comment -

        Not completely sure why this was closed without comment except that maybe the patch was out of date with the latest CVS. I have a new patch including a few more testcases migrated to work against the absolute latest CVS version of JMock. However, apparently closed reports don't allow attaching new patches. Is it simply not desired to move to using the latest JMock? If so, I'll quit pestering. If not, please reopen this so I can attach a new patch.

        Jake

        Show
        Jacob Kjome added a comment - Not completely sure why this was closed without comment except that maybe the patch was out of date with the latest CVS. I have a new patch including a few more testcases migrated to work against the absolute latest CVS version of JMock. However, apparently closed reports don't allow attaching new patches. Is it simply not desired to move to using the latest JMock? If so, I'll quit pestering. If not, please reopen this so I can attach a new patch. Jake

          People

          • Assignee:
            Aslak Hellesøy
            Reporter:
            Jacob Kjome
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: