Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: PicoContainer (Java)
-
Labels:None
-
Number of attachments :
Description
FolderContentPoller had some unnecessary members and a method used only for test. By choosing a better lock guard and using interrupt states of the thread, these could be removed. Additionally the run method now notifies waiting threads and therefore the test can do without sleep.
Activity
Jörg Schaible
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Attachment | FolderContentPoller.java.diff [ 11517 ] |
Test case without sleep. Note: It was the first time I worked with JMock. Therefore I reordered the "expected" lines to get a better understanding.
Show
Jörg Schaible
added a comment - Test case without sleep. Note: It was the first time I worked with JMock. Therefore I reordered the "expected" lines to get a better understanding.
Jörg Schaible
added a comment - Test case without sleep. Note: It was the first time I worked with JMock. Therefore I reordered the "expected" lines to get a better understanding. Jörg Schaible
made changes -
| Attachment | FolderContentPollerTestCase.java.diff [ 11518 ] |
Sorry for qualifying this issue as bug and without version info ... it's getting late.
Show
Jörg Schaible
added a comment - Sorry for qualifying this issue as bug and without version info ... it's getting late.
Jörg Schaible
added a comment - Sorry for qualifying this issue as bug and without version info ... it's getting late. thanks!
Show
Aslak Hellesøy
added a comment - thanks!
Aslak Hellesøy
added a comment - thanks! Aslak Hellesøy
made changes -
| Resolution | Fixed [ 1 ] | |
| Assignee | Aslak Hellesoy [ rinkrank ] | |
| Status | Open [ 1 ] | Closed [ 6 ] |
Optimized version of FolderContentPoller.java