Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Won't Fix
-
Affects Version/s: 1.0-RC-1
-
Fix Version/s: None
-
Component/s: PicoContainer (Java)
-
Labels:None
-
Number of attachments :
Description
Just an oversight?
DefaultPicoContainer defines ComponentAdapter registerComponentImplementation(Object componentKey, Class componentImplementation, List parameters), but MutablePicoContainer does not contain it. Only the variant with "Parameter[]" as third argument is part of the interface.
Activity
Generics would be really fine (and remember Generics just needs the code to be compiled with 1.5, Sun promises the binary runs also with older JDK's). But we could do this already with a list and check for Parameter instances. Currently the default implementation just turns the list into a Parameter[], we could easily do the other way round. I just care about the interface of MutablePicoContainer. IMHO it does not harm to add the List version to the API before 1.0 final, but prevents from a change later on.
Jörg Schaible
added a comment - Generics would be really fine (and remember Generics just needs the code to be compiled with 1.5, Sun promises the binary runs also with older JDK's). But we could do this already with a list and check for Parameter instances. Currently the default implementation just turns the list into a Parameter[], we could easily do the other way round. I just care about the interface of MutablePicoContainer. IMHO it does not harm to add the List version to the API before 1.0 final, but prevents from a change later on. Jörg Schaible
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Status | Open [ 1 ] | Closed [ 6 ] |
| Resolution | Won't Fix [ 2 ] |
I added the method taking a list in order to be able to call the method from Groovy. (Groovy "arrays" are in fact java.util.Lists).
I think we should keep it only on the implementation for the moment. When/if generics take off, we should maybe turn this into a List<Parameter> ?