Details
-
Type:
Improvement
-
Status:
Closed
-
Priority:
Major
-
Resolution: Won't Fix
-
Affects Version/s: 1.0-RC-1
-
Fix Version/s: None
-
Component/s: PicoContainer (Java)
-
Labels:None
-
Number of attachments :
Description
Do we still need the InstantiatingComponentAdapter? Now, that the BeanComponentAdapter is a delegate, we have only ConstructorInjectingComponentAdapter as derived class and ICA is nearly emtpy. What's the purpose of the class now?
Activity
No problem. I just asked, because my origninal (never supplied) patch had a lot more functionality in ICA than in CICA. I just shuffled the rest to CICA, because you started to do so with your refactoring. Looking at CICA we have some functions that also don't use reflection at all (like verify) and we could put them back (by introducing again some of the abstract protected methods). But it's possibly just a matter of taste now.
Jörg Schaible
added a comment - No problem. I just asked, because my origninal (never supplied) patch had a lot more functionality in ICA than in CICA. I just shuffled the rest to CICA, because you started to do so with your refactoring. Looking at CICA we have some functions that also don't use reflection at all (like verify) and we could put them back (by introducing again some of the abstract protected methods). But it's possibly just a matter of taste now. Ok,
Let's keep it and postpone (re) refactoring of ICA and CICA till its needed. I.e. When/if we get new impls of ICA and we realise that code from CICA can be reused.
Aslak Hellesøy
added a comment - Ok,
Let's keep it and postpone (re) refactoring of ICA and CICA till its needed. I.e. When/if we get new impls of ICA and we realise that code from CICA can be reused. Aslak Hellesøy
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Resolution | Won't Fix [ 2 ] | |
| Status | Open [ 1 ] | Closed [ 6 ] |
We don't strictly need it now. But I quite like the fact that it is completely dissociated from the java.lang.reflect API. It might be useful to derive other classes from it later, and we have a nice abstraction for that now.
Let's keep it.