PicoContainer
  1. PicoContainer
  2. PICO-161

Code clean-up before releasing final

          Details

          • Type: Task Task
          • Status: Closed Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.0-RC-1
          • Fix Version/s: 1.0-RC-1
          • Component/s: PicoContainer (Java)
          • Labels:
            None
          • Number of attachments :
            1

            Description

            Before we release 1.0 final we should clean up the code:

            • fix javadoc errors reported by Maven javadoc-plugin
            • fix useful warnings of Eclipse in code
            • add missing javadoc to public API
            • fix wrong or missing tags in existing javadoc

              Issue Links

              depends upon

              Bug - A problem which impairs or prevents the functions of the product. PICO-160 Design flaw working with JavaBeans

              • Critical - Crashes, loss of data, severe memory leak.
              • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

              Bug - A problem which impairs or prevents the functions of the product. PICO-167 SICA fails order of instantiation for dependencies

              • Major - Major loss of function.
              • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

                Activity

                Hide
                Permalink
                Konstantin Pribluda added a comment -

                I can help ( pending codehaus approval of my public key in HAUS-378 )

                Show
                Konstantin Pribluda added a comment - I can help ( pending codehaus approval of my public key in HAUS-378 )
                Hide
                Permalink
                Jörg Schaible added a comment -

                Additional topic:

                • Harmonize implementations (e.g. some CAs are Serializable, some not)
                Show
                Jörg Schaible added a comment - Additional topic: Harmonize implementations (e.g. some CAs are Serializable, some not)
                Permalink
                Jörg Schaible logged work - 26/Mar/04 4:15 PM
                • Time Spent:
                  15 minutes
                   
                  fix errors reported by javadoc
                Jörg Schaible made changes -
                Field Original Value New Value
                Time Spent 15 minutes [ 900 ]
                Hide
                Permalink
                Leo Simons added a comment -

                status? Anyone working on this? I'll help javadoc, but I don't want to step on people's toes.

                Show
                Leo Simons added a comment - status? Anyone working on this? I'll help javadoc, but I don't want to step on people's toes.
                Hide
                Permalink
                Leo Simons added a comment -

                started work on javadocs and code beautification of the main org.picocontainer package....

                Show
                Leo Simons added a comment - started work on javadocs and code beautification of the main org.picocontainer package....
                Jörg Schaible made changes -
                Link This issue depends upon PICO-160 [ PICO-160 ]
                Hide
                Permalink
                Jörg Schaible added a comment -

                Just added two dependencies for outstanding patches, that will have priority.

                Show
                Jörg Schaible added a comment - Just added two dependencies for outstanding patches, that will have priority.
                Jörg Schaible made changes -
                Link This issue depends upon PICO-167 [ PICO-167 ]
                Hide
                Permalink
                Leo Simons added a comment -

                code reformatting, javadocs, and some basic code security courtesy of IDEA and its InspectionGadgets plugin for the core org.picocontainer package (not for subpackages).

                Show
                Leo Simons added a comment - code reformatting, javadocs, and some basic code security courtesy of IDEA and its InspectionGadgets plugin for the core org.picocontainer package (not for subpackages).
                Leo Simons made changes -
                Attachment javadocs-for-org.picocontainer.patch.txt [ 11930 ]
                Hide
                Permalink
                Leo Simons added a comment -

                note that the patches in the dependency issues do not conflict with this one as they apply to a different set of sourcefiles.

                Show
                Leo Simons added a comment - note that the patches in the dependency issues do not conflict with this one as they apply to a different set of sourcefiles.
                Hide
                Permalink
                Leo Simons added a comment -

                sorry, the previous patch had a few javadoc errors. Please discard it and use this second one ("v2") instead.

                Show
                Leo Simons added a comment - sorry, the previous patch had a few javadoc errors. Please discard it and use this second one ("v2") instead.
                Leo Simons made changes -
                Attachment javadocs-for-org.picocontainer.patch-v2.txt [ 11932 ]
                Jörg Schaible made changes -
                Attachment javadocs-for-org.picocontainer.patch.txt [ 11930 ]
                Hide
                Permalink
                Leo Simons added a comment -

                I'm getting started on the javadocs for the defaults package. Please assign me...

                Show
                Leo Simons added a comment - I'm getting started on the javadocs for the defaults package. Please assign me...
                Hide
                Permalink
                Jörg Schaible added a comment -

                Please wait with documentation for ICA, CICA(Factory) and SICA(Factory) until PICO-167 is resolved. I wait now about 4 weeks for Aslak to review it and I have updated the patch several times.

                Show
                Jörg Schaible added a comment - Please wait with documentation for ICA, CICA(Factory) and SICA(Factory) until PICO-167 is resolved. I wait now about 4 weeks for Aslak to review it and I have updated the patch several times.
                Hide
                Permalink
                Aslak Hellesøy added a comment -

                What's pending for this issue? Can we close it?

                Show
                Aslak Hellesøy added a comment - What's pending for this issue? Can we close it?
                Aslak Hellesøy made changes -
                Status Open [ 1 ] Closed [ 6 ]
                Resolution Fixed [ 1 ]

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Jörg Schaible
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Time Tracking

                      Estimated:
                      Original Estimate - Not Specified
                      Not Specified
                      Remaining:
                      Remaining Estimate - Not Specified
                      Not Specified
                      Logged:
                      Time Spent - 15 minutes
                      15m