PicoContainer
  1. PicoContainer
  2. PICO-178

PicoContainer.getComponentAdaptersOfType() returns unmodifiable list

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0-RC-1
    • Fix Version/s: 1.0-RC-1
    • Component/s: PicoContainer (Java)
    • Labels:
      None
    • Number of attachments :
      1

      Description

      PicoContainer.getComponentAdapters() returns an unmodifiable collection, while PicoContainer.getComponentAdaptersOfType() currently returns a modifiable list. I suggest for safety and consistency that the returned list be made unmodifiable.

        Activity

        Hide
        Leo Simons added a comment -

        patch to implement the requested behaviour and add a test that checks it.

        Show
        Leo Simons added a comment - patch to implement the requested behaviour and add a test that checks it.
        Leo Simons made changes -
        Field Original Value New Value
        Attachment unmodifiableList-for-DefaultPicoContainer.patch.txt [ 11931 ]
        Hide
        Jörg Schaible added a comment -

        Thanks.

        Show
        Jörg Schaible added a comment - Thanks.
        Jörg Schaible made changes -
        Fix Version/s 1.0-RC-1 [ 10461 ]
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Leo Simons
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 3 minutes
              3m
              Remaining:
              Remaining Estimate - 3 minutes
              3m
              Logged:
              Time Spent - Not Specified
              Not Specified