PicoContainer
  1. PicoContainer
  2. PICO-182

Avoid unnecessary type conversion in ClassHierarchyIntrospector.getAllInterfaces

          Details

          • Type: Improvement Improvement
          • Status: Closed Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.0-RC-1
          • Fix Version/s: 1.0-RC-1
          • Component/s: PicoContainer (Java)
          • Labels:
            None
          • Number of attachments :
            0

            Description

            Looking at the callers of the ClassHierarchyIntrospector.getAllInterfaces it is obvious, that it does not make sense to convert the internally used Set to a Java array for the result, since every caller will have to modify this array and either creates a new one or simply convert the array back to a Set.

            ==> Return the Set directly.

              Activity

              Hide
              Permalink
              Aslak Hellesøy added a comment -

              Good call.

              I am about to propose the move of some classes (including CHI, the multicaster and implementation hiding core stuff) that are not strictly pico related to the proxytoys project at Codehaus. There is no doco for it yet, but it is mentioned here: http://xjb.codehaus.org/nullobjects.html

              Until I make the proposal on the dev list, let's hold this.

              Aslak

              Show
              Aslak Hellesøy added a comment - Good call. I am about to propose the move of some classes (including CHI, the multicaster and implementation hiding core stuff) that are not strictly pico related to the proxytoys project at Codehaus. There is no doco for it yet, but it is mentioned here: http://xjb.codehaus.org/nullobjects.html Until I make the proposal on the dev list, let's hold this. Aslak
              Hide
              Permalink
              Jörg Schaible added a comment -

              Well, I was too fast. Already fixed

              Show
              Jörg Schaible added a comment - Well, I was too fast. Already fixed
              Jörg Schaible made changes -
              Field Original Value New Value
              Resolution Fixed [ 1 ]
              Status Open [ 1 ] Closed [ 6 ]

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Jörg Schaible
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: