PicoContainer
  1. PicoContainer
  2. PICO-205

greedy non-public constructors are prefered over public constructors leading to IllegalAccessExceptions [patch]

          Details

          • Type: Bug Bug
          • Status: Closed Closed
          • Priority: Major Major
          • Resolution: Duplicate
          • Affects Version/s: 1.0
          • Fix Version/s: 1.1
          • Component/s: PicoContainer (Java)
          • Labels:
            None
          • Number of attachments :
            1

            Description

            After introducing allowNonPublicClasses feature, a problem occurs whenever a class has a non-public satisfiable constructor accepting more parameters than the greediest public constructor and the CICA is running in normal (allowNonPublicClasses==false) mode. The non-public constructor is selected and IllegalAccessException occurs.

            I've created a patch that ensures that only public constructors are considered as matching in allowNonPublicClasses==false mode.

              Issue Links

              duplicates

              Bug - A problem which impairs or prevents the functions of the product. PICO-201 PicoContainer finds the greediest constructor, even if it is protected or private

              • Major - Major loss of function.
              • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

                Activity

                Hide
                Permalink
                Rafal Krzewski added a comment -

                a patch that fixes the problem.

                Show
                Rafal Krzewski added a comment - a patch that fixes the problem.
                Rafal Krzewski made changes -
                Field Original Value New Value
                Attachment PICO-205.diff [ 12843 ]
                Hide
                Permalink
                Jörg Schaible added a comment -

                Already fixed.

                Show
                Jörg Schaible added a comment - Already fixed.
                Jörg Schaible made changes -
                Link This issue duplicates PICO-201 [ PICO-201 ]
                Jörg Schaible made changes -
                Resolution Duplicate [ 3 ]
                Fix Version/s 1.1 [ 10307 ]
                Status Open [ 1 ] Closed [ 6 ]
                Hide
                Permalink
                Rafal Krzewski added a comment -

                Ah, I see it was fixed on the trunk. How about applying my patch on PICOCONTAINER_RELEASE_1_0_BRANCH and releasing pico 1.0.1?

                Show
                Rafal Krzewski added a comment - Ah, I see it was fixed on the trunk. How about applying my patch on PICOCONTAINER_RELEASE_1_0_BRANCH and releasing pico 1.0.1?
                Hide
                Permalink
                Jörg Schaible added a comment -

                There's also a released pico-1.1-beta-1. Can you use it?
                In any case I would apply the (compatible) changes from HEAD, since I run in a maintenace nightmare otherwise.

                Show
                Jörg Schaible added a comment - There's also a released pico-1.1-beta-1. Can you use it? In any case I would apply the (compatible) changes from HEAD, since I run in a maintenace nightmare otherwise.

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Rafal Krzewski
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: