PicoContainer
  1. PicoContainer
  2. PICO-221

Enable ComponentAdapterFactory for visitor

          Details

          • Type: Improvement Improvement
          • Status: Closed Closed
          • Priority: Minor Minor
          • Resolution: Fixed
          • Affects Version/s: 1-1-beta-2, 2.2
          • Fix Version/s: 2.3
          • Component/s: PicoContainer (Java)
          • Labels:
            None
          • Number of attachments :
            0

            Description

            The PicoVisitor should be enhanced to visit also the ComponentAdapterFactory classes. This will help the convenience PicoContainers to examine the CAF chain.

              Activity

              Jörg Schaible made changes -
              Field Original Value New Value
              Environment
              Fix Version/s 1.3 [ 11331 ]
              Michael Rimov made changes -
              Comment [ According to the PicoVisitor interface, there is a
              ]
              Hide
              Permalink
              Michael Rimov added a comment -

              Ok. Take two.

              According to PicoVisitor interface, there is a method:

              void visitComponentAdapter(ComponentAdapter componentAdapter);

              And javadocs say its been there since Version 1.1?

              Is this still valid?

              Show
              Michael Rimov added a comment - Ok. Take two. According to PicoVisitor interface, there is a method: void visitComponentAdapter(ComponentAdapter componentAdapter); And javadocs say its been there since Version 1.1? Is this still valid?
              Hide
              Permalink
              Jörg Schaible added a comment -

              Yes, because the issue is about having a method:

              void visitComponentAdapterFactory(ComponentAdapterFactory componentAdapterFactory);

              it was never implemented, since the CAF is not one of the core Pico interfaces. So the issue is open unless we find the time for some kind of refactoring.

              Show
              Jörg Schaible added a comment - Yes, because the issue is about having a method: void visitComponentAdapterFactory(ComponentAdapterFactory componentAdapterFactory); it was never implemented, since the CAF is not one of the core Pico interfaces. So the issue is open unless we find the time for some kind of refactoring.
              Hide
              Permalink
              Michael Rimov added a comment -

              Oh duh, yes, gee.. there IS a difference between ComponentAdapter and ComponentAdapterFactory. My Mistake.

              -Mike (R)

              Show
              Michael Rimov added a comment - Oh duh, yes, gee.. there IS a difference between ComponentAdapter and ComponentAdapterFactory. My Mistake. -Mike (R)
              Michael Rimov made changes -
              Fix Version/s 1.3 [ 11331 ]
              Affects Version/s 2.2 [ 14251 ]
              Fix Version/s 2.3 [ 14303 ]
              Paul Hammant made changes -
              Assignee Joerg Schaible [ joehni ] Paul Hammant [ paul ]
              Hide
              Permalink
              Paul Hammant added a comment -

              Done.

              We do need a VerifyingVisitorTestCase though !

              Show
              Paul Hammant added a comment - Done. We do need a VerifyingVisitorTestCase though !
              Paul Hammant made changes -
              Status Open [ 1 ] Closed [ 6 ]
              Resolution Fixed [ 1 ]

                People

                • Assignee:
                  Paul Hammant
                  Reporter:
                  Jörg Schaible
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: