PicoContainer
  1. PicoContainer
  2. PICO-228

Better implementation(s) of DefaultLifecycleManager

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2
    • Component/s: PicoContainer (Java)
    • Labels:
      None
    • Number of attachments :
      3

      Description

      The current impl of DefaultLifecycleManger is flawed. The one registered against the root container will affect all child containers regardless of whether they may have been instantiated with their own impl of LifecycleManager. This is because the visitor impementation is a bit overzealous.

      Aslak and I have talked of fixing this. I changed it locally and let Aslak look at the changes. He's mulled it and proposed an alternate fix to the problem. That was about eight weeks ago, and we both sit not applying our loal changes.

      This issue should give us a chance to upload our patches for some debate on the way ahead.

      1. DefaultLifecycleManager.patch
        17 kB
        Paul Hammant
      2. RootVisitingLifecycleManager.java
        3 kB
        Paul Hammant
      3. RootVisitingLifecycleManagerTestCase.java
        3 kB
        Paul Hammant

        Activity

        Hide
        Paul Hammant added a comment -

        Patch for Pauls 'better' DLM

        Show
        Paul Hammant added a comment - Patch for Pauls 'better' DLM
        Paul Hammant made changes -
        Field Original Value New Value
        Attachment DefaultLifecycleManager.patch [ 13651 ]
        Hide
        Paul Hammant added a comment -

        Old DLM renamed under Paul's 'better' design

        Show
        Paul Hammant added a comment - Old DLM renamed under Paul's 'better' design
        Paul Hammant made changes -
        Attachment RootVisitingLifecycleManager.java [ 13652 ]
        Hide
        Paul Hammant added a comment -

        Renamed testcase (no longer functioning) under Pauls solution

        Show
        Paul Hammant added a comment - Renamed testcase (no longer functioning) under Pauls solution
        Paul Hammant made changes -
        Jörg Schaible made changes -
        Environment
        Fix Version/s 1.2 [ 11330 ]
        Hide
        Paul Hammant added a comment -

        resolved some time ago.

        Show
        Paul Hammant added a comment - resolved some time ago.
        Paul Hammant made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Jörg Schaible
            Reporter:
            Paul Hammant
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: