PicoContainer
  1. PicoContainer
  2. PICO-256

Inheritance over composition for CachingPicoContainer etc (to debate)

    Details

    • Type: New Feature New Feature
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2-RC1
    • Fix Version/s: 2.3
    • Component/s: PicoContainer (Java)
    • Labels:
      None
    • Number of attachments :
      0

      Description

      Takes over from PICO-212

        Activity

        Paul Hammant made changes -
        Field Original Value New Value
        Description Takes over from PICO-212
        Jörg Schaible made changes -
        Affects Version/s 1.2-RC1 [ 11979 ]
        Component/s PicoContainer (Java) [ 10191 ]
        Hide
        Paul Hammant added a comment -

        After the rework of CachingPC (and others) to be more consistent in their design, I'm not sure the move to Inheritance from Composition is warranted now.

        Historically we moved from inheritance designs to composition for many bits of pico in order to hide internal implementation more effectively from users ..

        Show
        Paul Hammant added a comment - After the rework of CachingPC (and others) to be more consistent in their design, I'm not sure the move to Inheritance from Composition is warranted now. Historically we moved from inheritance designs to composition for many bits of pico in order to hide internal implementation more effectively from users ..
        Hide
        Jörg Schaible added a comment -

        The argumentation is no different as before. If you have registered components with ThreadLocalCA, EJBClientCA, PoolingCA, HotSwappingCA, ... the wrapper changes or breaks theri functionality.

        Show
        Jörg Schaible added a comment - The argumentation is no different as before. If you have registered components with ThreadLocalCA, EJBClientCA, PoolingCA, HotSwappingCA, ... the wrapper changes or breaks theri functionality.
        Hide
        Michael Rimov added a comment -

        Isn't this issue no longer relevant with Pico 2? Can we close it?

        Show
        Michael Rimov added a comment - Isn't this issue no longer relevant with Pico 2? Can we close it?
        Hide
        Michael Rimov added a comment -

        I believe this was fixed in Pico-2 designs.

        Show
        Michael Rimov added a comment - I believe this was fixed in Pico-2 designs.
        Michael Rimov made changes -
        Fix Version/s 2.3 [ 14303 ]
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Paul Hammant
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 4 hours
              4h
              Remaining:
              Remaining Estimate - 4 hours
              4h
              Logged:
              Time Spent - Not Specified
              Not Specified