PicoContainer
  1. PicoContainer
  2. PICO-268

Add Constructor as parameter to InstantiatingComponentAdapter.createDefaultParameters

          Details

          • Type: Improvement Improvement
          • Status: Closed Closed
          • Priority: Major Major
          • Resolution: Won't Fix
          • Affects Version/s: None
          • Fix Version/s: 1.2
          • Component/s: PicoContainer (Java)
          • Labels:
            None
          • Number of attachments :
            0

            Description

            InstantiatingComponentAdapter.createDefaultParameters should receive the Constructor instance as a method argument.

            This will allow for subclasses of ICA to override createDefaultParameters and access any Annodations that may be present.

              Issue Links

              is related to

              Improvement - An improvement or enhancement to an existing feature or task. PICO-181 refactor creation of default parameters

              • Minor - Minor loss of function, or other problem where easy workaround is present.
              • Open - The issue is open and ready for the assignee to start work on it.

                Activity

                Jörg Schaible made changes -
                Field Original Value New Value
                Link This issue is depended upon by PICO-181 [ PICO-181 ]
                Hide
                Permalink
                Jörg Schaible added a comment -

                Note, this is scheduled for 1.3

                Show
                Jörg Schaible added a comment - Note, this is scheduled for 1.3
                Jörg Schaible made changes -
                Link This issue is depended upon by PICO-181 [ PICO-181 ]
                Jörg Schaible made changes -
                Link This issue is related to PICO-181 [ PICO-181 ]
                Hide
                Permalink
                Jörg Schaible added a comment -

                Fix relationship.

                Show
                Jörg Schaible added a comment - Fix relationship.
                Hide
                Permalink
                Paul Hammant added a comment -

                ctor param added.

                Peter - what to do with SICA ? I'm passing a null in as constructors not so pertinent to SDI components.

                Show
                Paul Hammant added a comment - ctor param added. Peter - what to do with SICA ? I'm passing a null in as constructors not so pertinent to SDI components.
                Paul Hammant made changes -
                Resolution Fixed [ 1 ]
                Status Open [ 1 ] Resolved [ 5 ]
                Hide
                Permalink
                peter royal added a comment -

                in an ideal world, CICA and SICA would pass in the annotations that are associated with the parameter to createDefaultParameters. that'd require java5 though.

                perhaps slightly different sigs for now?

                Parameter[] createDefaultParameters( Method[] setters, Class[] types ) {
                List parameters;

                for( Class type : types )

                { parameters.add( createDefaultParameter( type ) ); }
                }

                Parameter[] createDefaultParameters( Constructor cxtor, Class[] types ) {
                List parameters;

                for( Class type : types ) { parameters.add( createDefaultParameter( type ) ); }

                }

                Parameter createDefaultParameter( Class types )

                { // existing behavior for a single parameter }

                ... that way things could be overridden for Java5 as needed.

                Show
                peter royal added a comment - in an ideal world, CICA and SICA would pass in the annotations that are associated with the parameter to createDefaultParameters. that'd require java5 though. perhaps slightly different sigs for now? Parameter[] createDefaultParameters( Method[] setters, Class[] types ) { List parameters; for( Class type : types ) { parameters.add( createDefaultParameter( type ) ); } } Parameter[] createDefaultParameters( Constructor cxtor, Class[] types ) { List parameters; for( Class type : types ) { parameters.add( createDefaultParameter( type ) ); } } Parameter createDefaultParameter( Class types ) { // existing behavior for a single parameter } ... that way things could be overridden for Java5 as needed.
                Hide
                Permalink
                Paul Hammant added a comment -

                sure, go ahead and make the chg

                Show
                Paul Hammant added a comment - sure, go ahead and make the chg
                Hide
                Permalink
                peter royal added a comment -

                fully complete now, refactoring done as indicated.

                Show
                peter royal added a comment - fully complete now, refactoring done as indicated.
                peter royal made changes -
                Status Resolved [ 5 ] Closed [ 6 ]
                Hide
                Permalink
                peter royal added a comment -

                Will revert for 1.2 in favor of PICO-181 on 1.3

                Show
                peter royal added a comment - Will revert for 1.2 in favor of PICO-181 on 1.3
                peter royal made changes -
                Resolution Fixed [ 1 ]
                Status Closed [ 6 ] Reopened [ 4 ]
                Hide
                Permalink
                peter royal added a comment -

                backed out and will be handled by PICO-181 in future versions

                Show
                peter royal added a comment - backed out and will be handled by PICO-181 in future versions
                peter royal made changes -
                Resolution Won't Fix [ 2 ]
                Status Reopened [ 4 ] Resolved [ 5 ]
                peter royal made changes -
                Status Resolved [ 5 ] Closed [ 6 ]

                  People

                  • Assignee:
                    peter royal
                    Reporter:
                    peter royal
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: