PicoContainer
  1. PicoContainer
  2. PICO-269

ReflectionLCS does not support new lifecycleInvocationFailed event

          Details

          • Type: Bug Bug
          • Status: Closed Closed
          • Priority: Minor Minor
          • Resolution: Fixed
          • Affects Version/s: 1.2-RC1
          • Fix Version/s: 1.2
          • Component/s: PicoContainer (Java)
          • Labels:
            None
          • Number of attachments :
            0

            Description

            The new lifecycleInvocationFailed event of the ComponentMonitor should also be supported by the ReflectionLCS in gems.

              Activity

              Mauro Talevi made changes -
              Field Original Value New Value
              Summary ReflectionLC does not support new lifecycleFailure event ReflectionLCS does not support new lifecycleInvocationFailed event
              Description The new lifecycleFailure event of the ComponentMonitor should also be supported by the ReflectionLC in gems. The new lifecycleInvocationFailed event of the ComponentMonitor should also be supported by the ReflectionLCS in gems.
              Hide
              Permalink
              Mauro Talevi added a comment -

              Cannot invoke CM#lifecycleInvocationFailed() for IllegalAccessException and InvocationTargetException as they
              are checked exceptions and method expects RuntimeException as a param.
              Two options:
              1. change method signature to accept Exception
              2. wrap checked exception as RuntimeException

              I find 1. is preferrable and consistent with rest of CM method signatures.

              Show
              Mauro Talevi added a comment - Cannot invoke CM#lifecycleInvocationFailed() for IllegalAccessException and InvocationTargetException as they are checked exceptions and method expects RuntimeException as a param. Two options: 1. change method signature to accept Exception 2. wrap checked exception as RuntimeException I find 1. is preferrable and consistent with rest of CM method signatures.
              Mauro Talevi made changes -
              Assignee Mauro Talevi [ maurotalevi ] Paul Hammant [ paul ]
              Mauro Talevi made changes -
              Assignee Paul Hammant [ paul ] Mauro Talevi [ maurotalevi ]
              Hide
              Permalink
              Mauro Talevi added a comment -

              Used ReflectionLifecycleExceptions which are then thrown.

              Show
              Mauro Talevi added a comment - Used ReflectionLifecycleExceptions which are then thrown.
              Mauro Talevi made changes -
              Status Open [ 1 ] Closed [ 6 ]
              Resolution Fixed [ 1 ]

                People

                • Assignee:
                  Mauro Talevi
                  Reporter:
                  Jörg Schaible
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: