Details
-
Type:
Bug
-
Status:
Resolved
-
Priority:
Critical
-
Resolution: Fixed
-
Affects Version/s: 1.2-RC2
-
Fix Version/s: 1.2
-
Component/s: PicoContainer (Java)
-
Labels:None
-
Number of attachments :
Description
This fails (roughly, will make testcase later)
DPC parent = new DPC();
parent.start();
MPC child = parent.makeChildContainer();
child.start();
parent.stop();
// child container is never stopped since the parent container didn't start it. this used to work right 
Activity
I think a container needs to have a method to determine if it has been started or not. Then a parent container can stop all of its children that are started, regardless of how they were started. That should solve both needs.
peter royal
added a comment - I think a container needs to have a method to determine if it has been started or not. Then a parent container can stop all of its children that are started, regardless of how they were started. That should solve both needs. Failing test case added.
Easiest would be to add PicoContainer.isStarted(). Alternatively, some new interface that DPC could look at to tell if a child container has been started.
peter royal
added a comment - Failing test case added.
Easiest would be to add PicoContainer.isStarted(). Alternatively, some new interface that DPC could look at to tell if a child container has been started. For now I have assumed, that the added child container will take part on the current LC state of the parent. This is at least compatible.
Jörg Schaible
added a comment - For now I have assumed, that the added child container will take part on the current LC state of the parent. This is at least compatible. Jörg Schaible
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Assignee | Joerg Schaible [ joehni ] | |
| Resolution | Fixed [ 1 ] | |
| Fix Version/s | 1.2 [ 11330 ] | |
| Status | Open [ 1 ] | Resolved [ 5 ] |
This is a result of
PICO-263, see my comment from 2nd Dec. If we revert the change, I have a critical issue. Maybe we should add the added child containers to the list of started containers, if the container has been started. It seems that we really have to look at the LC in the different situations for the next release.