Details
-
Type:
Bug
-
Status:
Open
-
Priority:
Major
-
Resolution: Unresolved
-
Affects Version/s: 1.2
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
-
Number of attachments :
Description
If OrderedComponentAdapterLifecycleManager is used as the lifecycle manager it can crash if during the startup process more component adapters are added. The result is a java.util.ConcurrentModificationException.
The line:
adapters = orderedComponentAdapters;
should be changed to:
adapters = new ArrayList(orderedComponentAdapters);
so that it will work on a copy of the list instead of the list itself.
Activity
Hi Rickard,
can you elaborate a bit more about the your use case? The OCALM instantiates any startable component first and - since all of their dependencies must be satisfied - also any component not taking part of the LC is already instantiated if it is a dependency. So normally no new component should be added to the list. Please explain me, what you are doing, so I can at least create a test case.
- Jörg
Jörg Schaible
added a comment - Hi Rickard,
can you elaborate a bit more about the your use case? The OCALM instantiates any startable component first and - since all of their dependencies must be satisfied - also any component not taking part of the LC is already instantiated if it is a dependency. So normally no new component should be added to the list. Please explain me, what you are doing, so I can at least create a test case.
Jörg
Well, I'll have a look at this, but your fix is IMHO not the solution, because it is quite normal, that new elements are added to this list in start-up phase ... but I ned a closer look at the source.