Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Won't Fix
-
Affects Version/s: 2.2
-
Fix Version/s: 2.3
-
Component/s: PicoContainer (Java)
-
Labels:None
-
Testcase included:yes
-
Number of attachments :
Description
public void testLifecycleWhenSelfRegistered()
{ DefaultPicoContainer parent = new DefaultPicoContainer(); parent.registerComponentInstance(parent); parent.start(); // fails on latest parent.stop(); parent.dispose(); }
solution
private class OrderedComponentAdapterLifecycleManager
...
public void start(PicoContainer node) {
...
if (manager.hasLifecycle())
Activity
Posted my own scenario on the user list.
Michael Rimov
added a comment - Posted my own scenario on the user list. Mike,
I use transient containers for your case...
public void testLifecycleWhenSelfRegistered()
{ DefaultPicoContainer parent = new DefaultPicoContainer(); DefaultPicoContainer transient = new DefaultPicoContainer(); transient.registerComponentInstance(parent); transient.registerComponentInstance(....); // other components.. transient.start(); transient.dispose(); // optional ? transient = null; // unecessary drop of ref. }Can you give a bit more info as to what else is being registered in your 'parent' or in a child of ?
- Paul
Paul Hammant
added a comment - Mike,
I use transient containers for your case...
public void testLifecycleWhenSelfRegistered()
{
DefaultPicoContainer parent = new DefaultPicoContainer();
DefaultPicoContainer transient = new DefaultPicoContainer();
transient.registerComponentInstance(parent);
transient.registerComponentInstance(....); // other components..
transient.start();
transient.dispose(); // optional ?
transient = null; // unecessary drop of ref.
}
Can you give a bit more info as to what else is being registered in your 'parent' or in a child of ?
Paul
In my case, I cannot use a transient container... I need all these elements to be accessible from the parent container.
I need this feature to propagate the container reference to objects that register other classes. Why would this be an invalid scenario?
Erik
Erik Putrycz
added a comment - In my case, I cannot use a transient container... I need all these elements to be accessible from the parent container.
I need this feature to propagate the container reference to objects that register other classes. Why would this be an invalid scenario?
Erik Erik,
Can you upload a testcase?
I can't visualise the example from just your description..
- Paul
Paul Hammant
added a comment - Erik,
Can you upload a testcase?
I can't visualise the example from just your description..
Paul
Paul, see the discussion in the list.
Jörg Schaible
added a comment - Paul, see the discussion in the list. For anybody browsing, there is a discussion about how the ServiceLocator should be constructed to handle this. I've downgraded it to Major since a workaround is currently available.
Once consensus/sample result is available in SVN, this will probably be set to Won't Fix.
Michael Rimov
added a comment - For anybody browsing, there is a discussion about how the ServiceLocator should be constructed to handle this. I've downgraded it to Major since a workaround is currently available.
Once consensus/sample result is available in SVN, this will probably be set to Won't Fix. Michael Rimov
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Affects Version/s | 1.3 [ 11331 ] | |
| Affects Version/s | 1.2 [ 11330 ] | |
| Fix Version/s | 1.3 [ 11331 ] | |
| Priority | Blocker [ 1 ] | Major [ 3 ] |
| Affects Version/s | 1.1 [ 10307 ] | |
| Affects Version/s | 2.2 [ 14251 ] | |
| Fix Version/s | 2.3 [ 14303 ] |
Its a bad practice to let your components know of yourself. There are other solutions.
However, PicoContainer (the interface) with 2.x no longer extends Startable. Thus you should be able to wrap an ImmutablePicoContainer guard around the instance you are trying to self register and make it work w/o an attempt to call start() a second time on the container.
Paul Hammant
added a comment - Its a bad practice to let your components know of yourself. There are other solutions.
However, PicoContainer (the interface) with 2.x no longer extends Startable. Thus you should be able to wrap an ImmutablePicoContainer guard around the instance you are trying to self register and make it work w/o an attempt to call start() a second time on the container.
Paul Hammant
made changes -
| Assignee | Paul Hammant [ paul ] | |
| Resolution | Won't Fix [ 2 ] | |
| Status | Open [ 1 ] | Closed [ 6 ] |
Technically you're right, but we do not consider this scenario as valid. Please use the user's list to describe your use case.