Details
-
Type:
Wish
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.0
-
Fix Version/s: 2.2
-
Component/s: PicoContainer (Java)
-
Labels:None
-
Number of attachments :
Description
While org.picocontainer.PicoBuilderTestCase does indeed demonstrate the proper construction of a PicoContainer, my own problem with it is that every time a person is able to modify the internal structure of DefaultPicoContainer, PicoBuilder fails with something like 23 or so tests.
The result is that every time a private variable is changed, we must go in and edit the strings that xstream should be returning.
It seems to me that this isn't a very robust test case.
-Mike (R)
Activity
Yeah, I fixed it. XML is still used but the expected side of the assert is a hand crafted version of the same.
PicoBuilder is still our "worst" class though :- http://testabilityexplorer.org/picocontainer/picocontainer/2.1
Show
Paul Hammant
added a comment - Yeah, I fixed it. XML is still used but the expected side of the assert is a hand crafted version of the same.
PicoBuilder is still our "worst" class though :- http://testabilityexplorer.org/picocontainer/picocontainer/2.1
Paul Hammant
added a comment - Yeah, I fixed it. XML is still used but the expected side of the assert is a hand crafted version of the same.
PicoBuilder is still our "worst" class though :- http://testabilityexplorer.org/picocontainer/picocontainer/2.1 
Paul, I remember you were looking @ addressing this on the list since PicoBuilder still had lower test coverage %. Has this already been modified?