Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.2
-
Fix Version/s: 2.3
-
Component/s: PicoContainer Gems
-
Labels:None
-
Testcase included:yes
-
Number of attachments :
Description
Log4j and CommonsLogging are not Serializable and therefore, despite that ComponentMonitor is marked as Serializable, serialization isn't correct.
Test case:
@Test public void shouldSerialize() throws IOException, ClassNotFoundException
{ ByteArrayOutputStream bos = new ByteArrayOutputStream(); ObjectOutputStream oos = new ObjectOutputStream(bos); oos.writeObject(componentMonitor); oos.close(); byte[] savedBytes = bos.toByteArray(); assertNotNull(savedBytes); ByteArrayInputStream bis = new ByteArrayInputStream(savedBytes); ObjectInputStream ois = new ObjectInputStream(bis); this.componentMonitor = (ComponentMonitor) ois.readObject(); assertNotNull(componentMonitor); //Run through a couple of other tests so we know that the delegate logger internally //appears to be working. testShouldTraceInstantiatedWithInjected(); }Activity
Please drop this "defaultLoggerCategory" member completely. If you implement readObject, you can also implement writeObject and write the category directly into the object stream:
private void writeObject(ObjectOutputStream oos) throws IOException { oos.defaultWriteObject(); oos.writeObject(logger.getName()); } private void readObject(ObjectInputStream ois) throws IOException, ClassNotFoundException { ois.defaultReadObject(); logger = LoggerFactory.getLogger((String)ois.readObject()); }
No need to carry this extra member.
Show
Jörg Schaible
added a comment - Please drop this "defaultLoggerCategory" member completely. If you implement readObject, you can also implement writeObject and write the category directly into the object stream:
private void writeObject(ObjectOutputStream oos) throws IOException {
oos.defaultWriteObject();
oos.writeObject(logger.getName());
}
private void readObject(ObjectInputStream ois) throws IOException, ClassNotFoundException {
ois.defaultReadObject();
logger = LoggerFactory.getLogger(( String )ois.readObject());
}
No need to carry this extra member.
Jörg Schaible
added a comment - Please drop this "defaultLoggerCategory" member completely. If you implement readObject, you can also implement writeObject and write the category directly into the object stream:
private void writeObject(ObjectOutputStream oos) throws IOException {
oos.defaultWriteObject();
oos.writeObject(logger.getName());
}
private void readObject(ObjectInputStream ois) throws IOException, ClassNotFoundException {
ois.defaultReadObject();
logger = LoggerFactory.getLogger(( String )ois.readObject());
}
No need to carry this extra member. Good point Jörg, fixed and thanks.
(Hopefully you won't have to reopen again 
)
-Mike (R)
Show
Michael Rimov
added a comment - Good point Jörg, fixed and thanks.
(Hopefully you won't have to reopen again )
-Mike (R)
Michael Rimov
added a comment - Good point Jörg, fixed and thanks.
(Hopefully you won't have to reopen again )
-Mike (R) 
With the exception of
PICO-308, this has been fixed.