Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.9
-
Fix Version/s: 2.10
-
Component/s: PicoContainer (Java)
-
Labels:None
-
Environment:Windows Vista Business 64bit, Eclipse Galileo, Java 1.6.0_17 (64-bit)
-
Testcase included:yes
-
Number of attachments :
Description
Run the TestInjector test case in the attached Eclipse project to see the test fail. The output contains more information.
It seems that the "into" parameter of the getComponentInstance method of a FactoryInjector subclass (see AliceFactory in attachment) cannot be used to selectively inject different instances of a component based on the type of the class being injected into; it always resolves to be of type org.picocontainer.ComponentAdapter$NOTHING.
This should be possible as inferred from http://www.picocontainer.org/factory-injection.html.
-
Hide
-
-
TestInjector/.classpath
-
TestInjector/.project
-
TestInjector/.../org.eclipse.jdt.core.prefs
-
TestInjector/bin/.../injector/Alice.class
-
TestInjector/bin/.../AliceFactory$1.class
-
TestInjector/bin/.../AliceFactory.class
-
TestInjector/bin/test/.../injector/Bob.class
-
TestInjector/bin/.../TestInjector.class
-
TestInjector/lib/picocontainer-2.9.jar
-
TestInjector/src/.../injector/Alice.java
-
TestInjector/src/.../AliceFactory.java
-
TestInjector/src/test/.../injector/Bob.java
-
TestInjector/src/.../TestInjector.java
-
-
-
Hide
-
-
TestInjector/.classpath
-
TestInjector/.project
-
TestInjector/.../org.eclipse.jdt.core.prefs
-
TestInjector/bin/.../injector/Alice.class
-
TestInjector/bin/.../AliceFactory.class
-
TestInjector/bin/.../AliceImpl.class
-
TestInjector/bin/test/.../injector/Bob.class
-
TestInjector/bin/.../TestInjector.class
-
TestInjector/.../picocontainer-2.10-SNAPSHOT.jar
-
TestInjector/lib/picocontainer-2.8.jar
-
TestInjector/lib/picocontainer-2.9.jar
-
TestInjector/src/.../injector/Alice.java
-
TestInjector/src/.../AliceFactory.java
-
TestInjector/src/.../injector/AliceImpl.java
-
TestInjector/src/test/.../injector/Bob.java
-
TestInjector/src/.../TestInjector.java
-
-
Activity
I had to update AliceFactory to cast the 'into' parameter to InjectInto. Would be nice to have this documented...
Johan Hoogenboezem
added a comment - I had to update AliceFactory to cast the 'into' parameter to InjectInto. Would be nice to have this documented... awesome work. will apply later. what's your need in respect of a release ?
Paul Hammant
added a comment - awesome work. will apply later. what's your need in respect of a release ? I can use the snapshot I created, so there's no rush, thanks.
Johan Hoogenboezem
added a comment - I can use the snapshot I created, so there's no rush, thanks. Patch applied with thanks.
Paul Hammant
added a comment - Patch applied with thanks. 
Here's a patch:
Index: DefaultPicoContainer.java
===================================================================
DefaultPicoContainer.java (revision 5565)
+++ DefaultPicoContainer.java (working copy)
@@ -684,8 +684,7 @@
intoThreadLocal = new IntoThreadLocal();
}
}
+ instance = componentAdapter.getComponentInstance(this, intoThreadLocal.get());
}
} catch (AbstractInjector.CyclicDependencyException e) {
if (parent != null) {