Details
-
Type:
Improvement
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 2.13.5
-
Component/s: PicoContainer (Java)
-
Labels:None
-
Number of attachments :
Description
The Java EE 5 lifecycle support should invoke methods annotated with @PostConstruct and @PreDestroy also in inherited classes.
In the class JavaEE5LifecycleStrategy the methods hasLifeCycle() and doLifecycleMethod() should walk the type hierarchy and invoke methods in the proper order, taking into account if methods found has been overridden.
Activity
The destruction sequence should be reverse compared to the construction sequence. The test case should test for "post()subPost()subPre()pre()".
It needs to handle overridden methods as well, sadly there's no good support for this in the reflection api, it has to be done manually by comparing methods. Consider this class:
public static class ProPostAnnotationJava5Startable3 extends ProPostAnnotationJava5Startable { public ProPostAnnotationJava5Startable3(StringBuilder sb) { super(sb); } @PostConstruct @Override public void post() { sb.append("subPost3()"); } @PreDestroy public void subPre() { sb.append("subPre3()"); } }
With this test case:
@Test public void testLifecycleOfSubclassWhichOverrides(){ pico.removeComponent(ProPostAnnotationJava5Startable.class); pico.addComponent(ProPostAnnotationJava5Startable3.class); pico.start(); pico.dispose(); assertEquals("subPost3()subPre3()pre()", pico.getComponent(StringBuilder.class).toString()); }
It fails since it returns: subPost3()subPost3()pre()subPre3()
Also, it should be able to invoke private methods.
tobias mattsson
added a comment - The destruction sequence should be reverse compared to the construction sequence. The test case should test for "post()subPost()subPre()pre()".
It needs to handle overridden methods as well, sadly there's no good support for this in the reflection api, it has to be done manually by comparing methods. Consider this class:
public static class ProPostAnnotationJava5Startable3 extends ProPostAnnotationJava5Startable {
public ProPostAnnotationJava5Startable3(StringBuilder sb) {
super (sb);
}
@PostConstruct
@Override
public void post() {
sb.append( "subPost3()" );
}
@PreDestroy
public void subPre() {
sb.append( "subPre3()" );
}
}
With this test case:
@Test public void testLifecycleOfSubclassWhichOverrides(){
pico.removeComponent(ProPostAnnotationJava5Startable.class);
pico.addComponent(ProPostAnnotationJava5Startable3.class);
pico.start();
pico.dispose();
assertEquals( "subPost3()subPre3()pre()" , pico.getComponent(StringBuilder.class).toString());
}
It fails since it returns: subPost3()subPost3()pre()subPre3()
Also, it should be able to invoke private methods. 
Will https://fisheye.codehaus.org/changelog/picocontainer?cs=5790 do ?
If that's not reindexed by the time your get to it: see the new method in https://fisheye.codehaus.org/changelog/picocontainer?cs=5790
Specifically, its super-first FIFO, both for @PostConstruct and @PreDestroy.