port to proxytoys 1.0

The being-worked-on PicoContainer 3.0 uses ProxyToys 1.0:

https://github.com/paul-hammant/picocontainer/blob/master/pico/pom.xml

Most likely we're not going to back port to the 2.x codeline. Of course if you donated patch, we could well consume it and do a release.

Adapt gems module for use proxytoys 1.0.
the patch is based on your work for picocontainer 3.x

hi,
there are also some problems with the test suite. for container and gems modules
already added org.jmock:jmock module to the poms file as test dependence
but dont work
regards
p.s. open a new issue?

e.g.
testRemoveChildContainer(org.picocontainer.gems.containers.CommonsLoggingTracingContainerDecoratorTestCase) Time elapsed: 0.001 sec <<< ERROR!
java.lang.NoClassDefFoundError: org/jmock/internal/matcher/AllParametersMatcher
at org.jmock.internal.InvocationExpectationBuilder.createExpectationFrom(InvocationExpectationBuilder.java:92)
at org.jmock.internal.InvocationToExpectationTranslator.invoke(InvocationToExpectationTranslator.java:19)
at org.jmock.internal.FakeObjectMethods.invoke(FakeObjectMethods.java:38)
at org.jmock.lib.JavaReflectionImposteriser$1.invoke(JavaReflectionImposteriser.java:33)
at com.sun.proxy.$Proxy32.removeChildContainer(Unknown Source)
at org.picocontainer.gems.containers.AbstractTracingContainerDecoratorTest$20.<init>(AbstractTracingContainerDecoratorTest.java:421)
at org.picocontainer.gems.containers.AbstractTracingContainerDecoratorTest.testRemoveChildContainer(AbstractTracingContainerDecoratorTest.java:420)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:66)
at org.jmock.integration.junit4.JMock$1.invoke(JMock.java:37)
at org.junit.internal.runners.MethodRoadie.runTestMethod(MethodRoadie.java:105)
at org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:86)
at org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:94)
at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:84)
at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:49)
at org.junit.internal.runners.JUnit4ClassRunner.invokeTestMethod(JUnit4ClassRunner.java:98)
at org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:61)
at org.junit.internal.runners.JUnit4ClassRunner$1.run(JUnit4ClassRunner.java:54)
at org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:34)
at org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:44)
at org.junit.internal.runners.JUnit4ClassRunner.run(JUnit4ClassRunner.java:52)
at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)

Results :

Tests in error:
testObjectNameMustBeGiven(org.picocontainer.gems.jmx.AbstractConstructingProviderTest): org/hamcrest/TypeSafeDiagnosingMatcher
testMalformedObjectNameThrowsJMXRegistrationException(org.picocontainer.gems.jmx.AbstractConstructingProviderTest): org/jmock/internal/matcher/AllParametersMatcher
testCanCreateMBean(org.picocontainer.gems.jmx.AbstractConstructingProviderTest): org/jmock/internal/matcher/AllParametersMatcher
testVisitWithRegistration(org.picocontainer.gems.jmx.JMXVisitorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testVisitWithMultipleProviders(org.picocontainer.gems.jmx.JMXVisitorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testTraversal(org.picocontainer.gems.jmx.JMXVisitorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testFailingMBeanRegistration(org.picocontainer.gems.jmx.JMXVisitorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testMBeanInfoIsDeterminedIfKeyIsType(org.picocontainer.gems.jmx.ComponentKeyConventionMBeanInfoProviderTest): org/jmock/internal/matcher/AllParametersMatcher
testWillRegisterAndUnRegisterByDefaultComponentsThatAreMBeans(org.picocontainer.gems.jmx.JMXExposedTestCase): org/jmock/internal/matcher/AllParametersMatcher
testThrowsPicoInitializationExceptionIfMBeanIsAlreadyRegistered(org.picocontainer.gems.jmx.JMXExposedTestCase): org/jmock/internal/matcher/AllParametersMatcher
testThrowsPicoInitializationExceptionIfMBeanCannotBeRegistered(org.picocontainer.gems.jmx.JMXExposedTestCase): org/jmock/internal/matcher/AllParametersMatcher
testThrowsPicoInitializationExceptionIfMBeanNotCompliant(org.picocontainer.gems.jmx.JMXExposedTestCase): org/jmock/internal/matcher/AllParametersMatcher
testWillRegisterByDefaultComponentsThatAreMBeans(org.picocontainer.gems.jmx.JMXExposedTestCase): org/jmock/internal/matcher/AllParametersMatcher
testWillTryAnyDynamicMBeanProvider(org.picocontainer.gems.jmx.JMXExposedTestCase): org/jmock/internal/matcher/AllParametersMatcher
testRegisterWithoutComponentKey(org.picocontainer.gems.jmx.RegisteredMBeanConstructingProviderTest): org/jmock/internal/matcher/AllParametersMatcher
testRegisterWithTypedComponentKeyButWithoutMBeanInfo(org.picocontainer.gems.jmx.RegisteredMBeanConstructingProviderTest): org/jmock/internal/matcher/AllParametersMatcher
testRegisterWithArbitraryComponentKeyButWithoutMBeanInfo(org.picocontainer.gems.jmx.RegisteredMBeanConstructingProviderTest): org/jmock/internal/matcher/AllParametersMatcher
testRegisterWithArbitraryComponentKeyAndManagementInterface(org.picocontainer.gems.jmx.RegisteredMBeanConstructingProviderTest): org/jmock/internal/matcher/AllParametersMatcher
testRegisterWithArbitraryComponentKey(org.picocontainer.gems.jmx.RegisteredMBeanConstructingProviderTest): org/jmock/internal/matcher/AllParametersMatcher
testSpecificMBeanInfoIsFoundByType(org.picocontainer.gems.jmx.ComponentTypeConventionMBeanInfoProviderTest): org/jmock/internal/matcher/AllParametersMatcher
testDynamicMBeansWithMalformedObjectName(org.picocontainer.gems.jmx.DynamicMBeanComponentProviderTest): org/jmock/internal/matcher/AllParametersMatcher
testDynamicMBeansAreOnlyProvidedWithObjectName(org.picocontainer.gems.jmx.DynamicMBeanComponentProviderTest): org/jmock/internal/matcher/AllParametersMatcher
testPicoContainerIntegration(org.picocontainer.gems.jmx.JMXExposingTestCase): org/jmock/internal/matcher/AllParametersMatcher
testWillRegisterByDefaultComponentsThatAreMBeans(org.picocontainer.gems.jmx.JMXExposingTestCase): org/jmock/internal/matcher/AllParametersMatcher
testCollectionChildIdVisitedBreadthFirst(org.picocontainer.gems.constraints.ConstraintsTestCase): org/jmock/internal/matcher/AllParametersMatcher
testAndAllChildrenConstraintsTrueGivesTrue(org.picocontainer.gems.constraints.AndOrNotTestCase): org/jmock/internal/matcher/AllParametersMatcher
testAndAllChildrenAreVisitedBreadthFirst(org.picocontainer.gems.constraints.AndOrNotTestCase): org/jmock/internal/matcher/AllParametersMatcher
testOrAllChildrenConstraintsFalseGivesFalse(org.picocontainer.gems.constraints.AndOrNotTestCase): org/jmock/internal/matcher/AllParametersMatcher
testAndAllChildrenConstraintsTrueGivesTrueUsingAlternateConstructor(org.picocontainer.gems.constraints.AndOrNotTestCase): org/jmock/internal/matcher/AllParametersMatcher
testAndShortCircuitGivesFalse(org.picocontainer.gems.constraints.AndOrNotTestCase): org/jmock/internal/matcher/AllParametersMatcher
testOrAllChildrenAreVisitedBreadthFirst(org.picocontainer.gems.constraints.AndOrNotTestCase): org/jmock/internal/matcher/AllParametersMatcher
testMixingOrAndNot(org.picocontainer.gems.constraints.AndOrNotTestCase): org/jmock/internal/matcher/AllParametersMatcher
testNotChildIdVisitedBreadthFirst(org.picocontainer.gems.constraints.AndOrNotTestCase): org/jmock/internal/matcher/AllParametersMatcher
testRegisterComponent(org.picocontainer.gems.containers.Log4jTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testUnregisterComponent(org.picocontainer.gems.containers.Log4jTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testStart(org.picocontainer.gems.containers.Log4jTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testStop(org.picocontainer.gems.containers.Log4jTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testUnregisterComponentByInstance(org.picocontainer.gems.containers.Log4jTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testAccept(org.picocontainer.gems.containers.Log4jTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testAddChildContainer(org.picocontainer.gems.containers.Log4jTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testDispose(org.picocontainer.gems.containers.Log4jTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testGetComponentAdapter(org.picocontainer.gems.containers.Log4jTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testGetComponentAdapterOfType(org.picocontainer.gems.containers.Log4jTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testGetComponentAdapters(org.picocontainer.gems.containers.Log4jTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testGetComponentAdaptersOfType(org.picocontainer.gems.containers.Log4jTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testGetComponentInstance(org.picocontainer.gems.containers.Log4jTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testGetComponentInstances(org.picocontainer.gems.containers.Log4jTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testGetComponentInstancesOfType(org.picocontainer.gems.containers.Log4jTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testGetParent(org.picocontainer.gems.containers.Log4jTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testMakeChildContainer(org.picocontainer.gems.containers.Log4jTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testRegisterComponentImplementationClass(org.picocontainer.gems.containers.Log4jTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testRegisterComponentImplementationWithKeyAndClass(org.picocontainer.gems.containers.Log4jTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testRegisterComponentInstanceWithKey(org.picocontainer.gems.containers.Log4jTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testRegisterComponentImplementationObjectClassParameterArray(org.picocontainer.gems.containers.Log4jTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testRemoveChildContainer(org.picocontainer.gems.containers.Log4jTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testRegisterComponent(org.picocontainer.gems.containers.CommonsLoggingTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testUnregisterComponent(org.picocontainer.gems.containers.CommonsLoggingTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testStart(org.picocontainer.gems.containers.CommonsLoggingTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testStop(org.picocontainer.gems.containers.CommonsLoggingTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testUnregisterComponentByInstance(org.picocontainer.gems.containers.CommonsLoggingTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testAccept(org.picocontainer.gems.containers.CommonsLoggingTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testAddChildContainer(org.picocontainer.gems.containers.CommonsLoggingTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testDispose(org.picocontainer.gems.containers.CommonsLoggingTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testGetComponentAdapter(org.picocontainer.gems.containers.CommonsLoggingTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testGetComponentAdapterOfType(org.picocontainer.gems.containers.CommonsLoggingTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testGetComponentAdapters(org.picocontainer.gems.containers.CommonsLoggingTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testGetComponentAdaptersOfType(org.picocontainer.gems.containers.CommonsLoggingTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testGetComponentInstance(org.picocontainer.gems.containers.CommonsLoggingTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testGetComponentInstances(org.picocontainer.gems.containers.CommonsLoggingTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testGetComponentInstancesOfType(org.picocontainer.gems.containers.CommonsLoggingTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testGetParent(org.picocontainer.gems.containers.CommonsLoggingTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testMakeChildContainer(org.picocontainer.gems.containers.CommonsLoggingTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testRegisterComponentImplementationClass(org.picocontainer.gems.containers.CommonsLoggingTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testRegisterComponentImplementationWithKeyAndClass(org.picocontainer.gems.containers.CommonsLoggingTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testRegisterComponentInstanceWithKey(org.picocontainer.gems.containers.CommonsLoggingTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testRegisterComponentImplementationObjectClassParameterArray(org.picocontainer.gems.containers.CommonsLoggingTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher
testRemoveChildContainer(org.picocontainer.gems.containers.CommonsLoggingTracingContainerDecoratorTestCase): org/jmock/internal/matcher/AllParametersMatcher

Tests run: 349, Failures: 0, Errors: 77, Skipped: 0

for now "fixed" test suite removing

<junitArtifactName>junit:junit</junitArtifactName>
from pluginManagement>maven-surefire-plugin>configuration
and added as dep org.jmock:jmock and org.hamcrest:hamcrest-core
regards

result:

Failed tests: visitingClassesSiblingToAClassWithRegexSubsetWorksWithRecursive(org.picocontainer.classname.DefaultClassLoadingPicoContainerTestCase): expected:<org.picocontainer.[classname.ClassLoadingPicoContainer(..)
visitingClassesSiblingToAClassWithRegexSubsetWorksWithoutRecursive(org.picocontainer.classname.DefaultClassLoadingPicoContainerTestCase): expected:<...DefaultPicoContainer[$AsPropertiesPicoContainer(..)
visitingPassesIfClassInAJarRecursively(org.picocontainer.classname.DefaultClassLoadingPicoContainerTestCase): expected:<...houghtworks.xstream.[io.xml.xppdom.XppDom(..)

Tests in error:
nonMatchingCanFallThroughToAnotherComponentMonitor(org.picocontainer.monitors.RegexComposerTestCase)
testLifecycleCanRecoverWithCustomComponentMonitor(org.picocontainer.defaults.DefaultPicoContainerLifecycleTestCase)
testCanReallyChangeMonitor(org.picocontainer.defaults.issues.Issue0265TestCase)
testMonitoringHappensBeforeAndAfterInstantiation(org.picocontainer.defaults.AbstractComponentMonitorTestCase)
shouldProvideEmptyArgumentListForDefaultConstructor(org.picocontainer.injectors.SetterInjectorTestCase)
testMonitoringHappensBeforeAndAfterInstantiation(org.picocontainer.injectors.ConstructorInjectorTestCase)
testCachedComponentCanBeReinjectedByATransientReflectionMethodReinjector(org.picocontainer.injectors.ReinjectionTestCase)
testCachedComponentCanBeReinjectedByATransientMethodNameReinjector(org.picocontainer.injectors.ReinjectionTestCase)
testCachedComponentCanBeReinjectedByATransientAnnotatedMethodReinjector(org.picocontainer.injectors.ReinjectionTestCase)
testMonitorChanges(org.picocontainer.lifecycle.ReflectionLifecycleStrategyTestCase)
testDisposable(org.picocontainer.lifecycle.ReflectionLifecycleStrategyTestCase)
testWithDifferentTypes(org.picocontainer.lifecycle.ReflectionLifecycleStrategyTestCase)
testStartable(org.picocontainer.lifecycle.ReflectionLifecycleStrategyTestCase)

Tests run: 908, Failures: 3, Errors: 13, Skipped: 1