Details
-
Type: Improvement
-
Status: Closed
-
Priority: Minor
-
Resolution: Fixed
-
Affects Version/s: 1.0-RC-1
-
Component/s: PicoContainer (Java)
-
Labels:None
-
Number of attachments :
Description
Hey, (sorry my ssh cvs is broken around here somehow and I don't got the time to fix it yet.)
The current ConstructorInjectionComponentAdapter will always report all dependencies as unstatisfiable even if only one is missing. Just a quick patch will fix. I'll apply it when I get my ssh cvs fixed (should be by the weekend) or go ahead if you got a little moment.
? patch.txt
Index: src/java/org/picocontainer/defaults/ConstructorInjectionComponentAdapter.java
===================================================================
RCS file: /cvsroot/picocontainer/java/picocontainer/src/java/org/picocontainer/defaults/ConstructorInjectionComponentAdapter.java,v
retrieving revision 1.3
diff -b -u -r1.3 ConstructorInjectionComponentAdapter.java
src/java/org/picocontainer/defaults/ConstructorInjectionComponentAdapter.java 12 Mar 2004 11:26:19 -0000 1.3
+++ src/java/org/picocontainer/defaults/ConstructorInjectionComponentAdapter.java 24 Mar 2004 15:51:09 -0000
@@ -103,7 +103,7 @@
ComponentAdapter adapter = currentParameters[j].resolveAdapter(getContainer(), parameterTypes[j]);
if (adapter == null)
else {
// we can't depend on ourself
if (adapter.equals(this)) {
Issue Links
- duplicates
-
PICO-223 Improve CICA dependency error reporting
Activity
Field | Original Value | New Value |
---|---|---|
Resolution | Fixed [ 1 ] | |
Status | Open [ 1 ] | Closed [ 6 ] |
Status | Closed [ 6 ] | Reopened [ 4 ] |
Assignee | Thomas Heller [ maniax ] | Joerg Schaible [ joehni ] |
Resolution | Fixed [ 1 ] |
Component/s | PicoContainer (Java) [ 10191 ] | |
Fix Version/s | 1.2 [ 11330 ] | |
Environment | ||
Description |
Hey, (sorry my ssh cvs is broken around here somehow and I don't got the time to fix it yet.) The current ConstructorInjectionComponentAdapter will always report all dependencies as unstatisfiable even if only one is missing. Just a quick patch will fix. I'll apply it when I get my ssh cvs fixed (should be by the weekend) or go ahead if you got a little moment. ? patch.txt Index: src/java/org/picocontainer/defaults/ConstructorInjectionComponentAdapter.java =================================================================== RCS file: /cvsroot/picocontainer/java/picocontainer/src/java/org/picocontainer/defaults/ConstructorInjectionComponentAdapter.java,v retrieving revision 1.3 diff -b -u -r1.3 ConstructorInjectionComponentAdapter.java --- src/java/org/picocontainer/defaults/ConstructorInjectionComponentAdapter.java 12 Mar 2004 11:26:19 -0000 1.3 +++ src/java/org/picocontainer/defaults/ConstructorInjectionComponentAdapter.java 24 Mar 2004 15:51:09 -0000 @@ -103,7 +103,7 @@ ComponentAdapter adapter = currentParameters[j].resolveAdapter(getContainer(), parameterTypes[j]); if (adapter == null) { failedDependency = true; - unsatisfiableDependencyTypes.add(Arrays.asList(parameterTypes)); + unsatisfiableDependencyTypes.add(parameterTypes[j]); } else { // we can't depend on ourself if (adapter.equals(this)) { |
Hey, (sorry my ssh cvs is broken around here somehow and I don't got the time to fix it yet.) The current ConstructorInjectionComponentAdapter will always report all dependencies as unstatisfiable even if only one is missing. Just a quick patch will fix. I'll apply it when I get my ssh cvs fixed (should be by the weekend) or go ahead if you got a little moment. ? patch.txt Index: src/java/org/picocontainer/defaults/ConstructorInjectionComponentAdapter.java =================================================================== RCS file: /cvsroot/picocontainer/java/picocontainer/src/java/org/picocontainer/defaults/ConstructorInjectionComponentAdapter.java,v retrieving revision 1.3 diff -b -u -r1.3 ConstructorInjectionComponentAdapter.java --- src/java/org/picocontainer/defaults/ConstructorInjectionComponentAdapter.java 12 Mar 2004 11:26:19 -0000 1.3 +++ src/java/org/picocontainer/defaults/ConstructorInjectionComponentAdapter.java 24 Mar 2004 15:51:09 -0000 @@ -103,7 +103,7 @@ ComponentAdapter adapter = currentParameters[j].resolveAdapter(getContainer(), parameterTypes[j]); if (adapter == null) { failedDependency = true; - unsatisfiableDependencyTypes.add(Arrays.asList(parameterTypes)); + unsatisfiableDependencyTypes.add(parameterTypes[j]); } else { // we can't depend on ourself if (adapter.equals(this)) { |
Environment | ||
Fix Version/s | 1.2 [ 11330 ] | |
Fix Version/s | 1.3 [ 11331 ] |
Assignee | Joerg Schaible [ joehni ] | Mauro Talevi [ maurotalevi ] |
Fix Version/s | 1.2 [ 11330 ] | |
Fix Version/s | 1.3 [ 11331 ] | |
Description |
Hey, (sorry my ssh cvs is broken around here somehow and I don't got the time to fix it yet.) The current ConstructorInjectionComponentAdapter will always report all dependencies as unstatisfiable even if only one is missing. Just a quick patch will fix. I'll apply it when I get my ssh cvs fixed (should be by the weekend) or go ahead if you got a little moment. ? patch.txt Index: src/java/org/picocontainer/defaults/ConstructorInjectionComponentAdapter.java =================================================================== RCS file: /cvsroot/picocontainer/java/picocontainer/src/java/org/picocontainer/defaults/ConstructorInjectionComponentAdapter.java,v retrieving revision 1.3 diff -b -u -r1.3 ConstructorInjectionComponentAdapter.java --- src/java/org/picocontainer/defaults/ConstructorInjectionComponentAdapter.java 12 Mar 2004 11:26:19 -0000 1.3 +++ src/java/org/picocontainer/defaults/ConstructorInjectionComponentAdapter.java 24 Mar 2004 15:51:09 -0000 @@ -103,7 +103,7 @@ ComponentAdapter adapter = currentParameters[j].resolveAdapter(getContainer(), parameterTypes[j]); if (adapter == null) { failedDependency = true; - unsatisfiableDependencyTypes.add(Arrays.asList(parameterTypes)); + unsatisfiableDependencyTypes.add(parameterTypes[j]); } else { // we can't depend on ourself if (adapter.equals(this)) { |
Hey, (sorry my ssh cvs is broken around here somehow and I don't got the time to fix it yet.) The current ConstructorInjectionComponentAdapter will always report all dependencies as unstatisfiable even if only one is missing. Just a quick patch will fix. I'll apply it when I get my ssh cvs fixed (should be by the weekend) or go ahead if you got a little moment. ? patch.txt Index: src/java/org/picocontainer/defaults/ConstructorInjectionComponentAdapter.java =================================================================== RCS file: /cvsroot/picocontainer/java/picocontainer/src/java/org/picocontainer/defaults/ConstructorInjectionComponentAdapter.java,v retrieving revision 1.3 diff -b -u -r1.3 ConstructorInjectionComponentAdapter.java --- src/java/org/picocontainer/defaults/ConstructorInjectionComponentAdapter.java 12 Mar 2004 11:26:19 -0000 1.3 +++ src/java/org/picocontainer/defaults/ConstructorInjectionComponentAdapter.java 24 Mar 2004 15:51:09 -0000 @@ -103,7 +103,7 @@ ComponentAdapter adapter = currentParameters[j].resolveAdapter(getContainer(), parameterTypes[j]); if (adapter == null) { failedDependency = true; - unsatisfiableDependencyTypes.add(Arrays.asList(parameterTypes)); + unsatisfiableDependencyTypes.add(parameterTypes[j]); } else { // we can't depend on ourself if (adapter.equals(this)) { |
Type | Bug [ 1 ] | Improvement [ 4 ] |
Status | Reopened [ 4 ] | Closed [ 6 ] |
Resolution | Fixed [ 1 ] |
Done. I had to amend some tests too.