PicoContainer
  1. PicoContainer
  2. PICO-223

Improve CICA dependency error reporting

          Details

          • Type: Improvement Improvement
          • Status: Closed Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.1
          • Fix Version/s: 1.2
          • Component/s: PicoContainer (Java)
          • Labels:
            None
          • Number of attachments :
            0

            Description

            Currently in ConstructorInjectionComponentAdapter, when there are unsatisfiable dependencies found, the thrown exception contains all constructor parameters:

            Line 97:
            unsatisfiableDependencyTypes.add(Arrays.asList(parameterTypes));

            This is very unfriendly when somethings goes wrong in components wiring, and i would find it much more convenient to have the unsatisfiableDependencyTypes set to contain only the unsatisfiable dependencies.

            This can apparently be fixed by (for example...) simply replacing the line by:
            unsatisfiableDependencyTypes.add(parameterTypes[j]);

              Issue Links

              is duplicated by

              Improvement - An improvement or enhancement to an existing feature or task. PICO-157 CICA always reports all dependencies instead of only the missing ones

              • Minor - Minor loss of function, or other problem where easy workaround is present.
              • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

                Activity

                Hide
                Permalink
                Jörg Schaible added a comment -

                Current behaviour is due to PICO-157 and PICO-134. PICO-157 proposes an improvement in the following comments, that was never implemented.

                Show
                Jörg Schaible added a comment - Current behaviour is due to PICO-157 and PICO-134 . PICO-157 proposes an improvement in the following comments, that was never implemented.
                Jörg Schaible made changes -
                Field Original Value New Value
                Link This issue is duplicated by PICO-157 [ PICO-157 ]
                Jörg Schaible made changes -
                Fix Version/s 1.3 [ 11331 ]
                Environment
                Mauro Talevi made changes -
                Fix Version/s 1.3 [ 11331 ]
                Description Currently in ConstructorInjectionComponentAdapter, when there are unsatisfiable dependencies found, the thrown exception contains all constructor parameters:
                 
                Line 97:
                                unsatisfiableDependencyTypes.add(Arrays.asList(parameterTypes));
                 
                This is very unfriendly when somethings goes wrong in components wiring, and i would find it much more convenient to have the unsatisfiableDependencyTypes set to contain only the unsatisfiable dependencies.
                 
                This can apparently be fixed by (for example...) simply replacing the line by:
                                unsatisfiableDependencyTypes.add(parameterTypes[j]);                 		Currently in ConstructorInjectionComponentAdapter, when there are unsatisfiable dependencies found, the thrown exception contains all constructor parameters:
                 
                Line 97:
                                unsatisfiableDependencyTypes.add(Arrays.asList(parameterTypes));
                 
                This is very unfriendly when somethings goes wrong in components wiring, and i would find it much more convenient to have the unsatisfiableDependencyTypes set to contain only the unsatisfiable dependencies.
                 
                This can apparently be fixed by (for example...) simply replacing the line by:
                                unsatisfiableDependencyTypes.add(parameterTypes[j]);
                Fix Version/s 1.2 [ 11330 ]
                Hide
                Permalink
                Mauro Talevi added a comment -

                Fixed in PICO-157

                Show
                Mauro Talevi added a comment - Fixed in PICO-157
                Mauro Talevi made changes -
                Status Open [ 1 ] Closed [ 6 ]
                Resolution Fixed [ 1 ]

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Nicolas AVERSENG
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: