Ensure Pico 1.1 compatibility

differences between 1.1 and the current snapshot

Only error:

org.picocontainer.defaults.PicoInvocationTargetInitializationException
Removed org.picocontainer.PicoInstantiationException from the list of superclasses

restore 1.1-compatible cxtor

not sure if there is anything to do regarding the exception.

otherwise, this can go into a waiting state until we are ready to do a 1.2 RC

thanks for restoring CICA compat and I think you're right, we must continue here with the next RC.

Joerg - what is the status of this issue?

Need to run again now that we are done other changes to ensure nothing else broken.

May impact people:

org.picocontainer.alternatives.ImplementationHidingComponentAdapterFactory
Accessibility of method 'public ImplementationHidingComponentAdapterFactory()' has been decreased from public to package

org.picocontainer.defaults.InstantiatingComponentAdapter
Method 'protected org.picocontainer.Parameter[] createDefaultParameters(java.lang.Class[])' has been removed

org.picocontainer.defaults.SetterIntrospector
Class org.picocontainer.defaults.SetterIntrospector removed

Exception-Related:

org.picocontainer.defaults.PicoInvocationTargetInitializationException
Removed org.picocontainer.PicoInstantiationException from the list of superclasses

org.picocontainer.defaults.UnsatisfiableDependenciesException
In method 'public UnsatisfiableDependenciesException(org.picocontainer.ComponentAdapter, java.util.Set)' the number of arguments has changed

org.picocontainer.alternatives.ImplementationHidingComponentAdapterFactory
Accessibility of method 'public ImplementationHidingComponentAdapterFactory()' has been decreased from public to package

I am not sue I understand this. The class never had an excplicit default ctor.

org.picocontainer.defaults.InstantiatingComponentAdapter
Method 'protected org.picocontainer.Parameter[] createDefaultParameters(java.lang.Class[])' has been removed

This is a result of our last minute change in PICO-268 by Pete. I am not quite happy with it, since it contradicts what was proposed in PICO-181 and creates an incompatibility between release candidates. Annotation support would have been possible with PICO-181 also, but in a much more general manner.

Exceptions:
PITE: was thrown in different places, not only for places expecting a PIE. Review?
UDE: the exception is created internally, a ctor change should not make any difference.

IHCAF: It used to have a public no-args cxctor: http://svn.picocontainer.codehaus.org/java/picocontainer/trunk/container/src/java/org/picocontainer/defaults/ImplementationHidingComponentAdapterFactory.java?rev=2387&view=markup

ICA: I'm happy with PICO-181 functionality. But the ParameterFactory would need to get a handle to the element that the Class was for, namely the Constructor or Method to be able to pull annotations off. In pico2 we could always have the core container pass any annotations to the ParameterFactory and thus not have to worry about it. We can back out PICO-268 if it is a big deal as well.. I can manage that change in a private branch for my use.

Exceptions:
I do not think either of these are a concern.

If PICO-268 is controversial - and addressed by PICO-181 - I would revert.

I too think exceptions are fine.

Same from me. Revert PICO-268 and reopen it. I set the target version of PICO-181 to 1.3 exactly because it would change some API and I did not wanted to do it before 1.2 final.

As 1.2 has been released, moving this issue to future version for monitoring.
Any fixes should be done in 1.2.x

Since we're onto PIco 2.0, can we close this issue?

-Mike (R)

Nobody protested closing it earlier. Since our efforts have moved onto Pico 2, I'm closing it now.