Use PicoContainer as a factory of transient (unmanaged) objects.

Initial implementation

This has a lot of duplicate code from DefaultComponentAdapter. It will have to be refactored so it doesn't duplicate any code before it can be applied.

Aaargh. Never mind the last comment. I should learn to read patches in more detail before I comment. Looks good!

hi,

shouldn't DefaultComponentAdapter be non caching by default and caching done this way instead of another base class?

[code]

public class InstanceCachingAdapter extends DecoratingComponentAdapter {

private Object componentInstance = null;

public InstanceCachingAdapter(ComponentAdapter delegate)

public Object getComponentInstance(MutablePicoContainer container) throws PicoInitializationException, PicoIntrospectionException, AssignabilityRegistrationException, NotConcreteRegistrationException {
// FIXME: sync by extra adapter or here?
if (componentInstance == null)

return componentInstance;
}
}

[/code]

thoughts?

The things I'm not sure about:

1. Should it be possible to both cache and create fresh instances of the same component class by calling register, followed by create/get?

2. Should caching be the default?

As per disscusion today with Paul, a new patch that fixes a bug in the original patch- see testNewComponentInstancesNotCachedEvenIfClassIsRegisterd
for details.

This patch was diffed from HEAD and not from the previous patch.

Ok, I've implemented this based on a simplication of Zohars patch. See TransientComponentAdapter and TransientComponentAdapterTestCase. I have not changed the PicoContainer-interface but instead getComponentInstance always returns a new instance if you use the TransientComponentAdapter. So the above example would be:
container.registerComponentImplementation(CompA.class);
container.registerComponentImplementation(CompB.class);
container.registerComponent(new TransientComponentAdapter(WebworkAction.class, WebworkAction.class));

webworkAction = container.getComponentInstance(WebworkAction.class); // will return new instance each call